You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/20 17:39:24 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3374: Remove unnecessary flush calls on TrackedWrite

viirya commented on code in PR #3374:
URL: https://github.com/apache/arrow-rs/pull/3374#discussion_r1053578389


##########
parquet/src/file/writer.rs:
##########
@@ -326,7 +324,6 @@ impl<W: Write> SerializedFileWriter<W> {
         {
             let mut protocol = TCompactOutputProtocol::new(&mut self.buf);
             file_metadata.write_to_out_protocol(&mut protocol)?;
-            protocol.flush()?;

Review Comment:
   It simply flushed the inner writer (a `TWriteTransport: Write`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org