You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/08/27 00:21:11 UTC
[kudu-CR] docs: updates to kudu impala integration.adoc
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4138
to review the following change.
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
docs: updates to kudu_impala_integration.adoc
Note that this doc has diverged pretty substantially from its downstream
Cloudera counterpart, which is far more featureful.
Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
---
M docs/kudu_impala_integration.adoc
1 file changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/4138/1
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: updates to kudu impala integration.adoc
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4138
to look at the new patch set (#2).
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
docs: updates to kudu_impala_integration.adoc
Note that this doc has diverged pretty substantially from its downstream
Cloudera counterpart, which is far more featureful.
Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
---
M docs/kudu_impala_integration.adoc
1 file changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/4138/2
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: updates to kudu impala integration.adoc
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3154/
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: updates to kudu impala integration.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: updates to kudu impala integration.adoc
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: updates to kudu impala integration.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Just one nice-to-know question regarding CentOS. Otherwise lgtm.
http://gerrit.cloudera.org:8080/#/c/4138/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
Line 241: | RHEL | link:http://archive.cloudera.com/beta/impala-kudu/redhat/6/x86_64/impala-kudu/cloudera-impala-kudu.repo[RHEL 6],
BTW, what about CentOS? I would expect it to work on CentOS. Or we don't support CentOS because there is not enough interest in impala-kudu on that platform?
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: updates to kudu impala integration.adoc
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3098/
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: updates to kudu impala integration.adoc
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: updates to kudu impala integration.adoc
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4138/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
Line 241: | RHEL | link:http://archive.cloudera.com/beta/impala-kudu/redhat/6/x86_64/impala-kudu/cloudera-impala-kudu.repo[RHEL 6],
> BTW, what about CentOS? I would expect it to work on CentOS. Or we don't
These packages work on CentOS., it's just not explicitly documented here. I'll fix that.
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: updates to kudu impala integration.adoc
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: docs: updates to kudu_impala_integration.adoc
......................................................................
docs: updates to kudu_impala_integration.adoc
Note that this doc has diverged pretty substantially from its downstream
Cloudera counterpart, which is far more featureful.
Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Reviewed-on: http://gerrit.cloudera.org:8080/4138
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Dan Burkert <da...@cloudera.com>
---
M docs/kudu_impala_integration.adoc
1 file changed, 11 insertions(+), 5 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Alexey Serbin: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4138
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02a91f1c33be3f0d6fbffaef5e03832e21b6db70
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>