You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Andrew Lindesay (JIRA)" <ji...@apache.org> on 2010/03/07 10:24:27 UTC
[jira] Created: (CAY-1403) Method "readNestedProperty" Should
Resolve Through Iterative Invocations onto DataObject and Not Complete
Within Cayenne.readNestedProperty
Method "readNestedProperty" Should Resolve Through Iterative Invocations onto DataObject and Not Complete Within Cayenne.readNestedProperty
-------------------------------------------------------------------------------------------------------------------------------------------
Key: CAY-1403
URL: https://issues.apache.org/jira/browse/CAY-1403
Project: Cayenne
Issue Type: Improvement
Affects Versions: 3.0RC1
Reporter: Andrew Lindesay
(comes from email discussion with Andrus)
Another thing which may help me implement this for my own use is if the "readNestedProperty(..)" method were to iteratively be applied to DataObjects rather than to eventually hit Cayenne.readNestedProperty(..) and iterate in there. The entire nested property is currently parsed at the start, but if it iterated through the "readNestedProperty(..)" methods of the data objects then just the first part of the nested property could be 'parsed off'. The number of strings created from parsing the nested property would only be 2x the number compared to the current implementation.
---
I have taken a quick look at this, but there is not so much impetus to implement this right now. I will try to come back to it a bit later and submit a patch for it.
---
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1403) Method "readNestedProperty" Should
Resolve Through Iterative Invocations onto DataObject and Not Complete
Within Cayenne.readNestedProperty
Posted by "Andrew Lindesay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAY-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Lindesay updated CAY-1403:
---------------------------------
Fix Version/s: 3.0.2
Affects Version/s: 3.0.1
> Method "readNestedProperty" Should Resolve Through Iterative Invocations onto DataObject and Not Complete Within Cayenne.readNestedProperty
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAY-1403
> URL: https://issues.apache.org/jira/browse/CAY-1403
> Project: Cayenne
> Issue Type: Improvement
> Affects Versions: 3.0RC1, 3.0.1
> Reporter: Andrew Lindesay
> Fix For: 3.0.2
>
>
> (comes from email discussion with Andrus)
> Another thing which may help me implement this for my own use is if the "readNestedProperty(..)" method were to iteratively be applied to DataObjects rather than to eventually hit Cayenne.readNestedProperty(..) and iterate in there. The entire nested property is currently parsed at the start, but if it iterated through the "readNestedProperty(..)" methods of the data objects then just the first part of the nested property could be 'parsed off'. The number of strings created from parsing the nested property would only be 2x the number compared to the current implementation.
> ---
> I have taken a quick look at this, but there is not so much impetus to implement this right now. I will try to come back to it a bit later and submit a patch for it.
> ---
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1403) Method "readNestedProperty" Should
Resolve Through Iterative Invocations onto DataObject and Not Complete
Within Cayenne.readNestedProperty
Posted by "Andrew Lindesay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAY-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Lindesay updated CAY-1403:
---------------------------------
Attachment: cay-1403-patch.txt
This patch file changes the behaviour around this method; No patch is provided for 3.1 -- is it possible to merge this in or has there been too much change in 3.1 already?
> Method "readNestedProperty" Should Resolve Through Iterative Invocations onto DataObject and Not Complete Within Cayenne.readNestedProperty
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAY-1403
> URL: https://issues.apache.org/jira/browse/CAY-1403
> Project: Cayenne
> Issue Type: Improvement
> Affects Versions: 3.0RC1, 3.0.1
> Reporter: Andrew Lindesay
> Fix For: 3.0.2
>
> Attachments: cay-1403-patch.txt
>
>
> (comes from email discussion with Andrus)
> Another thing which may help me implement this for my own use is if the "readNestedProperty(..)" method were to iteratively be applied to DataObjects rather than to eventually hit Cayenne.readNestedProperty(..) and iterate in there. The entire nested property is currently parsed at the start, but if it iterated through the "readNestedProperty(..)" methods of the data objects then just the first part of the nested property could be 'parsed off'. The number of strings created from parsing the nested property would only be 2x the number compared to the current implementation.
> ---
> I have taken a quick look at this, but there is not so much impetus to implement this right now. I will try to come back to it a bit later and submit a patch for it.
> ---
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAY-1403) Method "readNestedProperty" Should
Resolve Through Iterative Invocations onto DataObject and Not Complete
Within Cayenne.readNestedProperty
Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAY-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrus Adamchik closed CAY-1403.
--------------------------------
Resolution: Fixed
Fix Version/s: 3.1M1
Applied the patch to 3.0. Needed to do some code juggling to combine static and OO implementations of readNestedProperty in 3.1. Hope I didn't miss anything.
> Method "readNestedProperty" Should Resolve Through Iterative Invocations onto DataObject and Not Complete Within Cayenne.readNestedProperty
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAY-1403
> URL: https://issues.apache.org/jira/browse/CAY-1403
> Project: Cayenne
> Issue Type: Improvement
> Affects Versions: 3.0RC1, 3.0.1
> Reporter: Andrew Lindesay
> Fix For: 3.0.2, 3.1M1
>
> Attachments: cay-1403-patch.txt
>
>
> (comes from email discussion with Andrus)
> Another thing which may help me implement this for my own use is if the "readNestedProperty(..)" method were to iteratively be applied to DataObjects rather than to eventually hit Cayenne.readNestedProperty(..) and iterate in there. The entire nested property is currently parsed at the start, but if it iterated through the "readNestedProperty(..)" methods of the data objects then just the first part of the nested property could be 'parsed off'. The number of strings created from parsing the nested property would only be 2x the number compared to the current implementation.
> ---
> I have taken a quick look at this, but there is not so much impetus to implement this right now. I will try to come back to it a bit later and submit a patch for it.
> ---
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-1403) Method "readNestedProperty" Should
Resolve Through Iterative Invocations onto DataObject and Not Complete
Within Cayenne.readNestedProperty
Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAY-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929414#action_12929414 ]
Andrus Adamchik commented on CAY-1403:
--------------------------------------
Thanks Andrew. I will take a look in a day or two. I am sure I can merge it to 3.1 with no problems if it works on 3.0
> Method "readNestedProperty" Should Resolve Through Iterative Invocations onto DataObject and Not Complete Within Cayenne.readNestedProperty
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CAY-1403
> URL: https://issues.apache.org/jira/browse/CAY-1403
> Project: Cayenne
> Issue Type: Improvement
> Affects Versions: 3.0RC1, 3.0.1
> Reporter: Andrew Lindesay
> Fix For: 3.0.2
>
> Attachments: cay-1403-patch.txt
>
>
> (comes from email discussion with Andrus)
> Another thing which may help me implement this for my own use is if the "readNestedProperty(..)" method were to iteratively be applied to DataObjects rather than to eventually hit Cayenne.readNestedProperty(..) and iterate in there. The entire nested property is currently parsed at the start, but if it iterated through the "readNestedProperty(..)" methods of the data objects then just the first part of the nested property could be 'parsed off'. The number of strings created from parsing the nested property would only be 2x the number compared to the current implementation.
> ---
> I have taken a quick look at this, but there is not so much impetus to implement this right now. I will try to come back to it a bit later and submit a patch for it.
> ---
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.