[jira] [Commented] (GEODE-5955) CacheClientUpdater statistics are created and never closed on failed initialization

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729200#comment-16729200 ] 

ASF subversion and git services commented on GEODE-5955:
--------------------------------------------------------

Commit 32399f0b162d0ee42f831d8a14f110e5742cec0b in geode's branch refs/heads/feature/GEODE-5955 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=32399f0 ]

GEODE-5955 CacheClientUpdater statistics are created and never closed on failed initialization

Close statistics if construction of a CacheClientUpdater fails.

I had to introduce a StatisticsProvider in order to inject a mock
statistics object into the CacheClientUpdater.  I also reworked the
"finally" block in the constructor to use the updater's close()
method.


> CacheClientUpdater statistics are created and never closed on failed initialization
> -----------------------------------------------------------------------------------
>
>                 Key: GEODE-5955
>                 URL: https://issues.apache.org/jira/browse/GEODE-5955
>             Project: Geode
>          Issue Type: Bug
>          Components: client queues
>            Reporter: Bruce Schuchardt
>            Assignee: Bruce Schuchardt
>            Priority: Minor
>              Labels: SmallFeature
>
> In a failed test run I found a client with a bunch of CacheClientUpdater statistics instances for a server that repeatedly rejected the client's attempts to create a subscription connection.  The stats all had the same "end time" of when the cache was closed.
> Normally when a CCU shuts down it closes its statistics.  This problem only occurs if the CCU fails to connect to the server and create its subscription queue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)