You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/04/04 20:11:39 UTC

Review Request 20036: Make sure a disk goes R/O for datanodes the datanodes are still started.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20036/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-5358
    https://issues.apache.org/jira/browse/AMBARI-5358


Repository: ambari


Description
-------

When a disk fails, the startup script executed by ambari will prevent the node
from starting due to an mkdir type operation on all directories. If the disk
is RO, the datanode will not use it, and if failed volumes is greater than 1,
it's valid to start a datanode in this case. Ambari won't let us.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py 50ef5e5 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py 95ace16 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py 5ad9eeb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 9387022 
  ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py b096a0d 
  ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_client.py a0d3dca 
  ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py 7a11d6e 
  ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py afc6d3f 
  ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_tasktracker.py 601bdd0 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8bdf654 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 369e686 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py e69dcfc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 8f694fc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f8cd4d3 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 0b15967 
  ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 2046f52 

Diff: https://reviews.apache.org/r/20036/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 20036: Make sure a disk goes R/O for datanodes the datanodes are still started.

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20036/#review39568
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On April 4, 2014, 6:12 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20036/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 6:12 p.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-5358
>     https://issues.apache.org/jira/browse/AMBARI-5358
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When a disk fails, the startup script executed by ambari will prevent the node
> from starting due to an mkdir type operation on all directories. If the disk
> is RO, the datanode will not use it, and if failed volumes is greater than 1,
> it's valid to start a datanode in this case. Ambari won't let us.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py 50ef5e5 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py 95ace16 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py 5ad9eeb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 9387022 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py b096a0d 
>   ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_client.py a0d3dca 
>   ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py 7a11d6e 
>   ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py afc6d3f 
>   ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_tasktracker.py 601bdd0 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8bdf654 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 369e686 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py e69dcfc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 8f694fc 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f8cd4d3 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 0b15967 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 2046f52 
> 
> Diff: https://reviews.apache.org/r/20036/diff/
> 
> 
> Testing
> -------
> 
> tests are green, deploy 1,2HDP
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 20036: Make sure a disk goes R/O for datanodes the datanodes are still started.

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20036/
-----------------------------------------------------------

(Updated April 4, 2014, 6:12 p.m.)


Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-5358
    https://issues.apache.org/jira/browse/AMBARI-5358


Repository: ambari


Description
-------

When a disk fails, the startup script executed by ambari will prevent the node
from starting due to an mkdir type operation on all directories. If the disk
is RO, the datanode will not use it, and if failed volumes is greater than 1,
it's valid to start a datanode in this case. Ambari won't let us.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py 50ef5e5 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py 95ace16 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py 5ad9eeb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 9387022 
  ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py b096a0d 
  ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_client.py a0d3dca 
  ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py 7a11d6e 
  ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py afc6d3f 
  ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_tasktracker.py 601bdd0 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8bdf654 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 369e686 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py e69dcfc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 8f694fc 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py f8cd4d3 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 0b15967 
  ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 2046f52 

Diff: https://reviews.apache.org/r/20036/diff/


Testing (updated)
-------

tests are green, deploy 1,2HDP


Thanks,

Andrew Onischuk