You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2020/01/17 21:04:37 UTC
Review Request 72025: ATLAS-3591: Improve user-defined properties
search
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72025/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, mayank jain, Nixon Rodrigues, and Sidharth Mishra.
Bugs: ATLAS-3591
https://issues.apache.org/jira/browse/ATLAS-3591
Repository: atlas
Description
-------
User-defined properties search is enabled in system attribute search. This Jira is improve the usability of the user-defined properties search.
For. e.g
"entityFilters": { "condition": "AND", "criterion": [ { "attributeName": "__customAttributes", "operator": "contains", "attributeValue": "key2=value2" } ] }
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 278b97faa
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java b2c1d4aa5
Diff: https://reviews.apache.org/r/72025/diff/1/
Testing
-------
Updated unit tests to test this improvement.
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1609/console
Thanks,
Sarath Subramanian
Re: Review Request 72025: ATLAS-3591: Improve user-defined properties
search
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72025/#review219332
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 20, 2020, 8:16 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72025/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2020, 8:16 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, mayank jain, Nixon Rodrigues, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3591
> https://issues.apache.org/jira/browse/ATLAS-3591
>
>
> Repository: atlas
>
>
> Description
> -------
>
> User-defined properties search is enabled in system attribute search. This Jira is improve the usability of the user-defined properties search.
>
> For. e.g
>
> "entityFilters": { "condition": "AND", "criterion": [ { "attributeName": "__customAttributes", "operator": "contains", "attributeValue": "key2=value2" } ] }
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 278b97faa
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java b2c1d4aa5
>
>
> Diff: https://reviews.apache.org/r/72025/diff/2/
>
>
> Testing
> -------
>
> Updated unit tests to test this improvement.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1609/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 72025: ATLAS-3591: Improve user-defined properties
search
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72025/
-----------------------------------------------------------
(Updated Jan. 20, 2020, 12:16 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, mayank jain, Nixon Rodrigues, and Sidharth Mishra.
Changes
-------
addressed review comments.
Bugs: ATLAS-3591
https://issues.apache.org/jira/browse/ATLAS-3591
Repository: atlas
Description
-------
User-defined properties search is enabled in system attribute search. This Jira is improve the usability of the user-defined properties search.
For. e.g
"entityFilters": { "condition": "AND", "criterion": [ { "attributeName": "__customAttributes", "operator": "contains", "attributeValue": "key2=value2" } ] }
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 278b97faa
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java b2c1d4aa5
Diff: https://reviews.apache.org/r/72025/diff/2/
Changes: https://reviews.apache.org/r/72025/diff/1-2/
Testing
-------
Updated unit tests to test this improvement.
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1609/console
Thanks,
Sarath Subramanian
Re: Review Request 72025: ATLAS-3591: Improve user-defined properties
search
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72025/#review219326
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 525 (patched)
<https://reviews.apache.org/r/72025/#comment307477>
when 'attrValue' doesn't contain CUSTOM_ATTR_SEPARATOR (i.e. '='), this method returns null. I suggest to return 'attrValue' in such case. This could be used to search user-defined properties for 'attrValue' in any property name or value. Please review.
if (key != null && value != null) {
ret = String.format(CUSTOM_ATTR_SEARCH_FORMAT, key, value);
} else {
ret = attrValue;
}
- Madhan Neethiraj
On Jan. 17, 2020, 9:04 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72025/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2020, 9:04 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, mayank jain, Nixon Rodrigues, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3591
> https://issues.apache.org/jira/browse/ATLAS-3591
>
>
> Repository: atlas
>
>
> Description
> -------
>
> User-defined properties search is enabled in system attribute search. This Jira is improve the usability of the user-defined properties search.
>
> For. e.g
>
> "entityFilters": { "condition": "AND", "criterion": [ { "attributeName": "__customAttributes", "operator": "contains", "attributeValue": "key2=value2" } ] }
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 278b97faa
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java b2c1d4aa5
>
>
> Diff: https://reviews.apache.org/r/72025/diff/1/
>
>
> Testing
> -------
>
> Updated unit tests to test this improvement.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1609/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 72025: ATLAS-3591: Improve user-defined properties
search
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72025/#review219324
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Line 94 (original), 98 (patched)
<https://reviews.apache.org/r/72025/#comment307474>
Revert the change since only qualifiers are changed.
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Line 112 (original), 116 (patched)
<https://reviews.apache.org/r/72025/#comment307475>
Revert to earlier version for better readability.
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 521 (patched)
<https://reviews.apache.org/r/72025/#comment307476>
Prefer: StringUtils.isNotEmpty(key)
- Ashutosh Mestry
On Jan. 17, 2020, 9:04 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72025/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2020, 9:04 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, mayank jain, Nixon Rodrigues, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3591
> https://issues.apache.org/jira/browse/ATLAS-3591
>
>
> Repository: atlas
>
>
> Description
> -------
>
> User-defined properties search is enabled in system attribute search. This Jira is improve the usability of the user-defined properties search.
>
> For. e.g
>
> "entityFilters": { "condition": "AND", "criterion": [ { "attributeName": "__customAttributes", "operator": "contains", "attributeValue": "key2=value2" } ] }
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 278b97faa
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java b2c1d4aa5
>
>
> Diff: https://reviews.apache.org/r/72025/diff/1/
>
>
> Testing
> -------
>
> Updated unit tests to test this improvement.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1609/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>