You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "gary murry (JIRA)" <ji...@apache.org> on 2009/06/02 00:31:07 UTC
[jira] Created: (HADOOP-5952) Hudson -1 wording change
Hudson -1 wording change
------------------------
Key: HADOOP-5952
URL: https://issues.apache.org/jira/browse/HADOOP-5952
Project: Hadoop Core
Issue Type: Test
Components: build
Reporter: gary murry
Assignee: Giridharan Kesavan
Priority: Minor
The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5952) Hudson -1 wording change
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715286#action_12715286 ]
gary murry commented on HADOOP-5952:
------------------------------------
The current wording is "-1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch." The new wording I would propose is "-1 tests include. The patch doesn't appear to include any new or modified test. Please justify why no tests are needed for this patch. Also please list what manual steps were performed to verify this patch." The wording was sent to core-dev@hadoop.apache.org with the only response being a +1 from Nigel.
> Hudson -1 wording change
> ------------------------
>
> Key: HADOOP-5952
> URL: https://issues.apache.org/jira/browse/HADOOP-5952
> Project: Hadoop Core
> Issue Type: Test
> Components: build
> Reporter: gary murry
> Assignee: Giridharan Kesavan
> Priority: Minor
>
> The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5952) Hudson -1 wording change
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723434#action_12723434 ]
Hudson commented on HADOOP-5952:
--------------------------------
Integrated in Hadoop-Common-trunk #6 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/6/])
. Change "-1 tests included" wording in test-patch.sh. Contributed by Gary Murry
> Hudson -1 wording change
> ------------------------
>
> Key: HADOOP-5952
> URL: https://issues.apache.org/jira/browse/HADOOP-5952
> Project: Hadoop Common
> Issue Type: Test
> Components: build
> Reporter: gary murry
> Assignee: gary murry
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HADOOP-5952.patch
>
>
> The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5952) Hudson -1 wording change
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715298#action_12715298 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5952:
------------------------------------------------
> ... Please justify why no tests are needed for this patch...
How about change it to "... Please justify why no new tests are needed for this patch..."?
In some cases, a patch may fix problems with existing failing unit tests, or it is a performance improvement (so the correctness is tested by the existing tests).
> Hudson -1 wording change
> ------------------------
>
> Key: HADOOP-5952
> URL: https://issues.apache.org/jira/browse/HADOOP-5952
> Project: Hadoop Core
> Issue Type: Test
> Components: build
> Reporter: gary murry
> Assignee: Giridharan Kesavan
> Priority: Minor
>
> The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5952) Hudson -1 wording change
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry updated HADOOP-5952:
-------------------------------
Attachment: HADOOP-5952.patch
Results from test-patch
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Note: not really +1 on tests included. But this does not need new tests since it is a minor chnge int he wording of test-patch.sh.
> Hudson -1 wording change
> ------------------------
>
> Key: HADOOP-5952
> URL: https://issues.apache.org/jira/browse/HADOOP-5952
> Project: Hadoop Core
> Issue Type: Test
> Components: build
> Reporter: gary murry
> Assignee: gary murry
> Priority: Minor
> Attachments: HADOOP-5952.patch
>
>
> The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5952) Hudson -1 wording change
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5952:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 new patch looks good.
> Hudson -1 wording change
> ------------------------
>
> Key: HADOOP-5952
> URL: https://issues.apache.org/jira/browse/HADOOP-5952
> Project: Hadoop Core
> Issue Type: Test
> Components: build
> Reporter: gary murry
> Assignee: gary murry
> Priority: Minor
> Attachments: HADOOP-5952.patch
>
>
> The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5952) Hudson -1 wording change
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725563#action_12725563 ]
Hadoop QA commented on HADOOP-5952:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12411136/HADOOP-5952.patch
against trunk revision 786278.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/console
This message is automatically generated.
> Hudson -1 wording change
> ------------------------
>
> Key: HADOOP-5952
> URL: https://issues.apache.org/jira/browse/HADOOP-5952
> Project: Hadoop Common
> Issue Type: Test
> Components: build
> Reporter: gary murry
> Assignee: gary murry
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HADOOP-5952.patch
>
>
> The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5952) Hudson -1 wording change
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry updated HADOOP-5952:
-------------------------------
Status: Patch Available (was: Open)
> Hudson -1 wording change
> ------------------------
>
> Key: HADOOP-5952
> URL: https://issues.apache.org/jira/browse/HADOOP-5952
> Project: Hadoop Core
> Issue Type: Test
> Components: build
> Reporter: gary murry
> Assignee: gary murry
> Priority: Minor
> Attachments: HADOOP-5952.patch
>
>
> The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5952) Hudson -1 wording change
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry reassigned HADOOP-5952:
----------------------------------
Assignee: gary murry (was: Giridharan Kesavan)
> Hudson -1 wording change
> ------------------------
>
> Key: HADOOP-5952
> URL: https://issues.apache.org/jira/browse/HADOOP-5952
> Project: Hadoop Core
> Issue Type: Test
> Components: build
> Reporter: gary murry
> Assignee: gary murry
> Priority: Minor
>
> The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5952) Hudson -1 wording change
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5952:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Gary!
> Hudson -1 wording change
> ------------------------
>
> Key: HADOOP-5952
> URL: https://issues.apache.org/jira/browse/HADOOP-5952
> Project: Hadoop Common
> Issue Type: Test
> Components: build
> Reporter: gary murry
> Assignee: gary murry
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HADOOP-5952.patch
>
>
> The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.