You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/11 09:26:09 UTC
[GitHub] [skywalking-cli] fgksgf opened a new pull request #54: Use template files in yaml format instead
fgksgf opened a new pull request #54:
URL: https://github.com/apache/skywalking-cli/pull/54
The original template file uses the `json` format, but `json` does not support comments and its readability is poor, so we decided to use the `yaml` format instead.
First, I rewrote the template file in `yaml` format, as an initial version to be discussed. Once the final format is determined, I will modify the corresponding code.
Besides, we need discuss:
+ Do we need use [viper](https://github.com/spf13/viper) to manage configuration?
+ Are there other commands that need template files? If so, we need determine their format too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #54: Use template files in yaml format instead
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #54:
URL: https://github.com/apache/skywalking-cli/pull/54#issuecomment-672974132
> + Do we need use [viper](https://github.com/spf13/viper) to manage configuration?
As we begin to tackle yaml configurations, it's ok to introduce viper lib, there should be many defaults that can save us a lot of time by viper
> + Are there other commands that need template files? If so, we need determine their format too.
For now, the other commands' options are not very complex, and they can share the same default values, so we just consider the dashboard command at the moment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] fgksgf commented on pull request #54: Use template files in yaml format instead
Posted by GitBox <gi...@apache.org>.
fgksgf commented on pull request #54:
URL: https://github.com/apache/skywalking-cli/pull/54#issuecomment-703227375
@kezhenxu94 If you think this `yaml` template is ok, I'll move on with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] codecov-io commented on pull request #54: Use template files in yaml format instead
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #54:
URL: https://github.com/apache/skywalking-cli/pull/54#issuecomment-706125865
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/b70fd193b6ec8dcca7017852fc1498162b5d18d5?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
=======================================
Coverage 48.59% 48.59%
=======================================
Files 8 8
Lines 107 107
=======================================
Hits 52 52
Misses 47 47
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=footer). Last update [b70fd19...a496cca](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] codecov-io commented on pull request #54: Use template files in yaml format instead
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #54:
URL: https://github.com/apache/skywalking-cli/pull/54#issuecomment-706125865
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/b70fd193b6ec8dcca7017852fc1498162b5d18d5?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
=======================================
Coverage 48.59% 48.59%
=======================================
Files 8 8
Lines 107 107
=======================================
Hits 52 52
Misses 47 47
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=footer). Last update [b70fd19...a496cca](https://codecov.io/gh/apache/skywalking-cli/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 merged pull request #54: Use template files in yaml format instead
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #54:
URL: https://github.com/apache/skywalking-cli/pull/54
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] fgksgf commented on pull request #54: Use template files in yaml format instead
Posted by GitBox <gi...@apache.org>.
fgksgf commented on pull request #54:
URL: https://github.com/apache/skywalking-cli/pull/54#issuecomment-673197862
> is this file requiring manual configuration?
The config file is default, only when users want to customize the dashboard (like changing colors of widgets, items to be displayed), they need manual configuration. The effect is similar to [this](https://github.com/apache/skywalking-cli/pull/46#issuecomment-664100438).
> It doesn't look like the one from UI-template service.
It seems there is currently no specification for UI-template. So we decide to define a format and the default template by ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng commented on pull request #54: Use template files in yaml format instead
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #54:
URL: https://github.com/apache/skywalking-cli/pull/54#issuecomment-673155087
By reading the config file, is this file requiring manual configuration? It doesn't look like the one from UI-template service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org