You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2010/11/19 18:56:17 UTC

[jira] Commented: (CASSANDRA-1729) Fix misuse of DataOutputBuffer.getData in AntiEntropyService

    [ https://issues.apache.org/jira/browse/CASSANDRA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933887#action_12933887 ] 

Hudson commented on CASSANDRA-1729:
-----------------------------------

Integrated in Cassandra-0.6 #9 (See [https://hudson.apache.org/hudson/job/Cassandra-0.6/9/])
    Fix misuse of DataOutputBuffer.getData in AntiEntropyService
patch by Stu Hood; reviewed by jbellis for CASSANDRA-1729


> Fix misuse of DataOutputBuffer.getData in AntiEntropyService
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-1729
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1729
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>            Priority: Minor
>             Fix For: 0.6.9
>
>         Attachments: 0001-Remove-varargs-from-FBUtilities.hash-and-correctly-use.txt
>
>
> As reported by Schubert Zhang, AntiEntropyService is ignoring the length of the input buffer.
> {code:java}
> byte[] rowhash = FBUtilities.hash("SHA-256", row.key.key.getBytes(), row.buffer.getData());
> {code}
> While this isn't affecting our accuracy, it would break validation if we started reusing buffers in CompactedRow. This issue has already been fixed in 0.7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.