[GitHub] [activemq-artemis] brusdev commented on a diff in pull request #4440: ARTEMIS-4244 Set web config using system properties

["brusdev (via GitHub)" <gi...@apache.org>]

brusdev commented on code in PR #4440:
URL: https://github.com/apache/activemq-artemis/pull/4440#discussion_r1172639065


##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Run.java:
##########
@@ -133,6 +133,8 @@ public void deActivate() {
             broker.components.add(broker.web);
          }
 
+         server.getServer().getConfiguration().parsePrefixedProperties(broker.web, "web", System.getProperties(), ActiveMQDefaultConfiguration.getDefaultWebPropertyPrefix());

Review Comment:
   @gtully  I don't have a strong opinion on propsId `web` and on prefix `webconfig.` but looking at the current values for the broker config (`system`, `brokerconfig.`) I was thinking at `system-web` and `brokerwebconfig.` WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org