You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/05/25 01:24:48 UTC

[GitHub] [calcite] hsyuan commented on a change in pull request #1235: [CALCITE-1956] Allow MultiJoin to chain multiple FULL joins

hsyuan commented on a change in pull request #1235: [CALCITE-1956] Allow MultiJoin to chain multiple FULL joins
URL: https://github.com/apache/calcite/pull/1235#discussion_r287546096
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/JoinToMultiJoinRule.java
 ##########
 @@ -417,7 +417,14 @@ private void copyOuterJoinInfo(
    * @param nullGenerating true if the input is null generating
    * @return true if the input can be combined into a parent MultiJoin
    */
-  private boolean canCombine(RelNode input, boolean nullGenerating) {
+  private boolean canCombine(RelNode input, JoinRelType type, boolean nullGenerating) {
 
 Review comment:
   Do we need `nullGenerating` since we can get it from `JoinRelType`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services