You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/12/09 13:00:03 UTC

[GitHub] [myfaces] werpu opened a new pull request, #417: Fix for https://issues.apache.org/jira/browse/MYFACES-4040

werpu opened a new pull request, #417:
URL: https://github.com/apache/myfaces/pull/417

   Fix for MYFACES-4040, in my own integration tests:
   
   
   ```xml
              <h:commandLink id="submitButton" value="Click here" action="#{myBean2.execute}">
                   <f:ajax execute="@this" render="output" />
                   <f:param name="hello2" value="Hello from f:param"/>
                   <f:param name="Hello World" value="Hello from f:param2"/>
                   <f:param name="render" value="output2"/>
                   <f:param name="execute" value="booga"/>
              </h:commandLink>
   
              <h:panelGroup id="results">
                   <h:outputText id="output" value="#{myBean2.helloWorld}"></h:outputText>
              </h:panelGroup>
   ```
   
   Now resolves to:
   
   ```html
   <a href="#" onclick="faces.util.chain(this, event,function(event){myfaces.ab(this,event,'action','submitButton','output',{params: {'hello2':'Hello from f:param','Hello World':'Hello from f:param2','render':'output2','execute':'booga'}})}); return false;" id="submitButton" name="submitButton">Click here</a>
   ```
   
   and the test which searches for an updated output element passes, the render and execute f:params arw now part of param
   Also the request parameters are now as following:
   
   ```javascript
   form1_SUBMIT: 1
   jakarta.faces.ViewState: ZDU1NmJhYjk2NmVjZDQ5YjAwMDAwMDJk
   hello2:  Hello from f:param
   Hello World: Hello from f:param2
   render: output2
   execute: booga
   jakarta.faces.behavior.event: action
   jakarta.faces.partial.event: click
   jakarta.faces.source: submitButton
   jakarta.faces.partial.ajax: true
   jakarta.faces.partial.execute: submitButton
   jakarta.faces.partial.render: output
   form1: form1
   ```
   @tandraschko , @volosied:  please test I wont merge the fix until you give the ok
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] werpu commented on pull request #417: Fix for https://issues.apache.org/jira/browse/MYFACES-4040

Posted by GitBox <gi...@apache.org>.
werpu commented on PR #417:
URL: https://github.com/apache/myfaces/pull/417#issuecomment-1344281745

   @volosied please review, I do not want to merge before you give the ok!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] werpu commented on pull request #417: Fix for https://issues.apache.org/jira/browse/MYFACES-4040

Posted by GitBox <gi...@apache.org>.
werpu commented on PR #417:
URL: https://github.com/apache/myfaces/pull/417#issuecomment-1344296038

   Also i will merge the port of this fix down up to 2.3 and 2.3-next on monday!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] volosied commented on pull request #417: Fix for https://issues.apache.org/jira/browse/MYFACES-4040

Posted by GitBox <gi...@apache.org>.
volosied commented on PR #417:
URL: https://github.com/apache/myfaces/pull/417#issuecomment-1344796326

   Just tested -- looks great! Thank you.  However, could you fix up the commit message?  It's a bit confusing with the revert revert beginning. 
   
   I don't have a strong opinion about 2.3. Let me see what @pnicolucci says. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] werpu merged pull request #417: Fix for https://issues.apache.org/jira/browse/MYFACES-4040

Posted by GitBox <gi...@apache.org>.
werpu merged PR #417:
URL: https://github.com/apache/myfaces/pull/417


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org