You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/06/09 05:02:12 UTC
[GitHub] [mynewt-core] vrahane opened a new pull request #2614: nrf5340: Conditional Rev A errata 26 fix
vrahane opened a new pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614
- As per Errata 26, CTRL-AP: APPROTECT.DISABLE and
SECUREAPPROTECT.DISABLE registers are not functional
- So we need to conditionally disable its usage
** BEFORE **
A `HardFault` would happen at `57 NRF_CTRLAP_S->APPROTECT.DISABLE = NRF_UICR_S->APPROTECT;` in `repos/apache-mynewt-core/hw/mcu/nordic/src/ext/nrfx/mdk/system_nrf5340_application.c` which would be seen in the bootloader.
** AFTER **
No `HardFault`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r648922768
##########
File path: hw/mcu/nordic/nrf5340/pkg.yml
##########
@@ -104,3 +104,10 @@ pkg.deps.I2C_3':
pkg.deps.NRF5340_EMBED_NET_CORE:
- "@apache-mynewt-core/hw/mcu/nordic/nrf5340/net_core_image"
+
+# As per Errata 26 for Engineering RevA silicon we should not
+# depend on CTRL-AP: APPROTECT.DISABLE and SECUREAPPROTECT.DISABLE
+# registers since they are not functional. It causes quite a lot of
+# crashes and hardfaults
+pkg.cflags.MCU_NRF5340_REVA_SILICON:
Review comment:
I'd not make this as revA workaround but rather a general config as provided by nrfx: enabled, user controlled and UICR controlled.
##########
File path: hw/mcu/nordic/nrf5340/syscfg.yml
##########
@@ -25,13 +25,15 @@ syscfg.defs:
- $notnull
choices:
- nRF5340_APP
+
MCU_APP_CORE:
description: >
Constant value always set to 1. It allows to have common
packages for network and application core that do have
some differences depending on which core they are build for.
value: 1
restriction: MCU_NET_CORE==0
Review comment:
isn't the real problem a typo above? restriction_S_ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2614: nrf5340: Conditional Rev A errata 26 fix
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#issuecomment-859855921
@sjanc Can you please review ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix
Posted by GitBox <gi...@apache.org>.
vrahane commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649485185
##########
File path: hw/mcu/nordic/nrf5340/syscfg.yml
##########
@@ -25,13 +25,15 @@ syscfg.defs:
- $notnull
choices:
- nRF5340_APP
+
MCU_APP_CORE:
description: >
Constant value always set to 1. It allows to have common
packages for network and application core that do have
some differences depending on which core they are build for.
value: 1
restriction: MCU_NET_CORE==0
Review comment:
That restriction does not hold truth anymore since MCUs are different for both cores. I am removing it and updated description above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane merged pull request #2614: nrf5340: Conditional Rev A errata 26 fix
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix
Posted by GitBox <gi...@apache.org>.
vrahane commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649397245
##########
File path: hw/mcu/nordic/nrf5340/syscfg.yml
##########
@@ -25,13 +25,15 @@ syscfg.defs:
- $notnull
choices:
- nRF5340_APP
+
MCU_APP_CORE:
description: >
Constant value always set to 1. It allows to have common
packages for network and application core that do have
some differences depending on which core they are build for.
value: 1
restriction: MCU_NET_CORE==0
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2614: nrf5340: Conditional Rev A errata 26 fix
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#issuecomment-860862209
@sjanc done, I have mentioned Errata 26 in the detailed commit message because it is needed for that. Kept the commit message generic enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix
Posted by GitBox <gi...@apache.org>.
vrahane commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649380996
##########
File path: hw/mcu/nordic/nrf5340/syscfg.yml
##########
@@ -25,13 +25,15 @@ syscfg.defs:
- $notnull
choices:
- nRF5340_APP
+
MCU_APP_CORE:
description: >
Constant value always set to 1. It allows to have common
packages for network and application core that do have
some differences depending on which core they are build for.
value: 1
restriction: MCU_NET_CORE==0
Review comment:
I guess, I just wanted the build to restart so, I found something that needed fixing :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix
Posted by GitBox <gi...@apache.org>.
vrahane commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r649397141
##########
File path: hw/mcu/nordic/nrf5340/pkg.yml
##########
@@ -104,3 +104,10 @@ pkg.deps.I2C_3':
pkg.deps.NRF5340_EMBED_NET_CORE:
- "@apache-mynewt-core/hw/mcu/nordic/nrf5340/net_core_image"
+
+# As per Errata 26 for Engineering RevA silicon we should not
+# depend on CTRL-AP: APPROTECT.DISABLE and SECUREAPPROTECT.DISABLE
+# registers since they are not functional. It causes quite a lot of
+# crashes and hardfaults
+pkg.cflags.MCU_NRF5340_REVA_SILICON:
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org