You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "quantranhong1999 (via GitHub)" <gi...@apache.org> on 2023/04/17 11:08:13 UTC

[GitHub] [james-project] quantranhong1999 opened a new pull request, #1522: POC Code coverage for Apache James

quantranhong1999 opened a new pull request, #1522:
URL: https://github.com/apache/james-project/pull/1522

   TODO: declare children dependencies in `code-coverage-report` module


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #1522: POC Code coverage for Apache James

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1522:
URL: https://github.com/apache/james-project/pull/1522#issuecomment-1511147031

   Thanks for the effort.
   
   After seeing the results, and that we consider code coverage adoption seriously then we must discuss this on the mailing list.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #1522: POC Code coverage for Apache James

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1522:
URL: https://github.com/apache/james-project/pull/1522#issuecomment-1517212357

   ![Screenshot from 2023-04-21 10-35-42](https://user-images.githubusercontent.com/6928740/233535011-a6f4e691-7d97-44ad-a156-c8279fa99583.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #1522: POC Code coverage for Apache James

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1522:
URL: https://github.com/apache/james-project/pull/1522#issuecomment-1517209589

   ![Screenshot from 2023-04-21 10-29-00](https://user-images.githubusercontent.com/6928740/233534292-297e184b-077f-49d4-8959-70e42a5b0c92.png)
   
   Looks like scala support is so-so ... 
   
   Also, do we get a global aggregate?
   
   Per module view is nice, but an aggregate would be better....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #1522: POC Code coverage for Apache James

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1522:
URL: https://github.com/apache/james-project/pull/1522#issuecomment-1524962092

   IMO yes we can


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] Arsnael commented on pull request #1522: POC Code coverage for Apache James

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1522:
URL: https://github.com/apache/james-project/pull/1522#issuecomment-1517200636

   It seems the newer modules are the less covered in terms of tests (jmap, rate limiter, redis, rspamd, ...)
   
   Good job though :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #1522: POC Code coverage for Apache James

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1522:
URL: https://github.com/apache/james-project/pull/1522#issuecomment-1514445094

   
   09:14:02,578 [ERROR] No plugin found for prefix 'jacoco' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/home/jenkins/jenkins-agent/workspace/james_ApacheJames_PR-1522/.repository), Nexus (https://repository.apache.org/snapshots), central (https://repo.maven.apache.org/maven2)] -> [Help 1]
   org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin found for prefix 'jacoco' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/home/jenkins/jenkins-agent/workspace/james_ApacheJames_PR-1522/.repository), Nexus (https://repository.apache.org/snapshots), central (https://repo.maven.apache.org/maven2)]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] quantranhong1999 commented on pull request #1522: POC Code coverage for Apache James

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on PR #1522:
URL: https://github.com/apache/james-project/pull/1522#issuecomment-1517196057

   At least from 1 green build, we had a beautiful code coverage report:
   
   [code coverage James.webm](https://user-images.githubusercontent.com/55171818/233531240-ab61ebde-f993-40d2-a827-f4edcbfcfb66.webm)
   
   The archive: 
   [archive (1).zip](https://github.com/apache/james-project/files/11291907/archive.1.zip)
   
   Now I would polish the commits and expect a green build...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] Arsnael merged pull request #1522: POC Code coverage for Apache James

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #1522:
URL: https://github.com/apache/james-project/pull/1522


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] Arsnael commented on pull request #1522: POC Code coverage for Apache James

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #1522:
URL: https://github.com/apache/james-project/pull/1522#issuecomment-1524695302

   Can we merge this or not yet then?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-project] chibenwa commented on pull request #1522: POC Code coverage for Apache James

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1522:
URL: https://github.com/apache/james-project/pull/1522#issuecomment-1517215731

   Code coverage: 227,121 of 846,037 | 73%
   
   Modulo scala issues: likely 120,000 of 846,037 | 85%
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org