[GitHub] gigasquid commented on a change in pull request #13478: Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file

[GitBox <gi...@apache.org>]

gigasquid commented on a change in pull request #13478: Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file
URL: https://github.com/apache/incubator-mxnet/pull/13478#discussion_r238120584
 
 

 ##########
 File path: contrib/clojure-package/README.md
 ##########
 @@ -147,7 +147,7 @@ The first step is to recursively clone the MXNet repository and checkout the des
   ```bash
   git clone --recursive https://github.com/apache/incubator-mxnet.git ~/mxnet
   cd ~/mxnet
-  git checkout tags/1.4.0 -b my_mxnet  # this is optional
+  git checkout tags/1.5.0 -b my_mxnet  # this is optional
 
 Review comment:
   It should point to the tag that corresponds to the jar on maven and the jars on maven are only for the last release. I'm assuming that it will be the 1.4.0 tag when this branch is merged (at least that's what I've been doing).  For reference when I do `git tag --list` I see:
   
   ```
   1.3.1
   1.3.1.rc0
   ```
   I'm not exactly sure of the timing of when this PR is merged though .. is that a correct assumption?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services