You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/15 15:43:37 UTC

[GitHub] [inlong] leosanqing opened a new pull request, #5558: [INLONG-5290][Manager] Optimize the objects returned by manager web paging queries

leosanqing opened a new pull request, #5558:
URL: https://github.com/apache/inlong/pull/5558

   
   ### Prepare a Pull Request
   
   - Fixes #5290 
   
   ### Motivation
   - The pageInfo object returned by the web contains too many unnecessary and unused fields
   - The client should not contain the PageHelper dependency
   
   ### Modifications
   - Modules: Client,Web(Controller)
   
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [x] This change is already covered by existing tests, such as:
       - PageResultTest 
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #5558: [INLONG-5290][Manager] Optimize the objects returned by manager web paging queries

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5558:
URL: https://github.com/apache/inlong/pull/5558#discussion_r950838491


##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/ConsumptionController.java:
##########
@@ -64,9 +65,9 @@ public Response<ConsumptionSummary> getSummary(ConsumptionQuery query) {
 
     @GetMapping("/consumption/list")
     @ApiOperation(value = "List data consumptions")
-    public Response<PageInfo<ConsumptionListVo>> list(ConsumptionQuery query) {
+    public Response<PageResult<ConsumptionListVo>> list(ConsumptionQuery query) {
         query.setUsername(LoginUserUtils.getLoginUser().getName());
-        return Response.success(consumptionService.list(query));
+        return Response.success(PageUtils.of(consumptionService.list(query)));

Review Comment:
   Why not encapsulate it directly into PageResult when querying in the Service layer?
   
   There is one more conversion operation of PageUtils, which is not very efficient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #5558: [INLONG-5290][Manager] Optimize the objects returned by manager web paging queries

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5558:
URL: https://github.com/apache/inlong/pull/5558#discussion_r950643949


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/common/PageResult.java:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.pojo.common;
+
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.Data;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.List;
+
+@Data
+@JsonIgnoreProperties(ignoreUnknown = true)
+@ApiModel("Paginated query results")
+public final class PageResult<T> implements Serializable {

Review Comment:
   Good idea.
   The PageInfo from PageHelper has so many parameters, which are not necessary for the caller.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #5558: [INLONG-5290][Manager] Optimize the objects returned by manager web paging queries

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5558:
URL: https://github.com/apache/inlong/pull/5558#discussion_r950643976


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/common/PageResult.java:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.pojo.common;
+
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.Data;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.List;
+
+@Data
+@JsonIgnoreProperties(ignoreUnknown = true)
+@ApiModel("Paginated query results")
+public final class PageResult<T> implements Serializable {

Review Comment:
   I will review it later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow merged pull request #5558: [INLONG-5290][Manager] Optimize the objects returned by manager web paging queries

Posted by GitBox <gi...@apache.org>.
healchow merged PR #5558:
URL: https://github.com/apache/inlong/pull/5558


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org