You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/07/02 18:30:51 UTC
[GitHub] [ignite] NSAmelchev opened a new pull request #7987: IGNITE-13109 Skip metastorage entries that can not be unmarshalled
NSAmelchev opened a new pull request #7987:
URL: https://github.com/apache/ignite/pull/7987
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7987: IGNITE-13109 Skip distributed metastorage entries that can not be unmarshalled
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7987:
URL: https://github.com/apache/ignite/pull/7987#discussion_r478351998
##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java
##########
@@ -1342,6 +1343,15 @@
*/
public static final String IGNITE_DUMP_TX_COLLISIONS_INTERVAL = "IGNITE_DUMP_TX_COLLISIONS_INTERVAL";
+ /**
+ * Newline separated list of keys that {@link DistributedMetaStorage} will skip for any operations:
Review comment:
Fixed with comma
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] NSAmelchev commented on a change in pull request #7987: IGNITE-13109 Skip distributed metastorage entries that can not be unmarshalled
Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7987:
URL: https://github.com/apache/ignite/pull/7987#discussion_r478352576
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java
##########
@@ -406,6 +432,9 @@ private void onMetaStorageReadyForWrite(ReadWriteMetastorage metastorage) {
/** {@inheritDoc} */
@Override @Nullable public <T extends Serializable> T read(@NotNull String key) throws IgniteCheckedException {
+ if (keysToSkip.contains(key))
Review comment:
Fixed. Explicit operations will not be ignored
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #7987: IGNITE-13109 Skip distributed metastorage entries that can not be unmarshalled
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #7987:
URL: https://github.com/apache/ignite/pull/7987#discussion_r478313985
##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java
##########
@@ -1342,6 +1343,15 @@
*/
public static final String IGNITE_DUMP_TX_COLLISIONS_INTERVAL = "IGNITE_DUMP_TX_COLLISIONS_INTERVAL";
+ /**
+ * Newline separated list of keys that {@link DistributedMetaStorage} will skip for any operations:
Review comment:
Why do we want to use a newline to separate list items?
It may be inconvenient to specify a multiline value in the bash script.
Let's use a comma as a separator like it done in `IGNITE_TCP_DISCOVERY_ADDRESSES`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #7987: IGNITE-13109 Skip distributed metastorage entries that can not be unmarshalled
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #7987:
URL: https://github.com/apache/ignite/pull/7987#discussion_r478320549
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java
##########
@@ -406,6 +432,9 @@ private void onMetaStorageReadyForWrite(ReadWriteMetastorage metastorage) {
/** {@inheritDoc} */
@Override @Nullable public <T extends Serializable> T read(@NotNull String key) throws IgniteCheckedException {
+ if (keysToSkip.contains(key))
Review comment:
Why do we disallow `read` operation?
All we need is skip keys that can't be unmarshalled on the node startup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org