You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/09 16:46:09 UTC

[GitHub] [arrow] pitrou commented on pull request #10895: ARROW-13574: [C++] Add count_all and hash_count_all kernels

pitrou commented on pull request #10895:
URL: https://github.com/apache/arrow/pull/10895#issuecomment-895376223


   Hmm... It's weird that `Count` takes `ScalarAggregateOptions`, yet 1) completely ignores `min_count` 2) has an unexpected interpretation of `skip_nulls`.
   
   Can we instead make `Count` take a `CountOptions` that would have a enum describing whether one wants to 1) count non-nulls 2) count nulls 3) count everything?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org