You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/02/09 14:41:22 UTC

[PR] refactor(metadata): invert state handler dependency [iggy]

hubcio opened a new pull request, #2705:
URL: https://github.com/apache/iggy/pull/2705

   Split define_state! into define_state! (struct + wrapper) and collect_handlers! (enum, Command, dispatch, Absorb). Each command type now implements StateHandler<S> for the state it mutates, moving handler logic from a central match block onto the command.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(metadata): invert state handler dependency [iggy]

Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #2705:
URL: https://github.com/apache/iggy/pull/2705


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(metadata): invert state handler dependency [iggy]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2705:
URL: https://github.com/apache/iggy/pull/2705#issuecomment-3872234807

   ## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2705?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0.65789%` with `302 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.82%. Comparing base ([`cc37464`](https://app.codecov.io/gh/apache/iggy/commit/cc37464487321d1b1b44952db6c6d1106b978cde?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3e8c098`](https://app.codecov.io/gh/apache/iggy/commit/3e8c0984f2de5129a9c622ff16f6ab6ac17aa85f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2705?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [core/metadata/src/stm/stream.rs](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fstream.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL3N0cmVhbS5ycw==) | 0.00% | [149 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [core/metadata/src/stm/user.rs](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fuser.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL3VzZXIucnM=) | 0.00% | [87 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [core/metadata/src/stm/consumer\_group.rs](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fconsumer_group.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL2NvbnN1bWVyX2dyb3VwLnJz) | 0.00% | [48 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [core/metadata/src/stm/mod.rs](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL21vZC5ycw==) | 10.00% | [17 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   :x: Your patch check has failed because the patch coverage (0.65%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2705      +/-   ##
   ==========================================
   - Coverage   68.83%   68.82%   -0.01%     
   ==========================================
     Files         574      575       +1     
     Lines       55668    55687      +19     
     Branches    55668    55687      +19     
   ==========================================
   + Hits        38318    38328      +10     
   - Misses      15477    15485       +8     
   - Partials     1873     1874       +1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/iggy/pull/2705/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [rust](https://app.codecov.io/gh/apache/iggy/pull/2705/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.82% <0.65%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2705?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [core/metadata/src/stm/mod.rs](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL21vZC5ycw==) | `41.79% <10.00%> (-4.12%)` | :arrow_down: |
   | [core/metadata/src/stm/consumer\_group.rs](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fconsumer_group.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL2NvbnN1bWVyX2dyb3VwLnJz) | `0.00% <0.00%> (ø)` | |
   | [core/metadata/src/stm/user.rs](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fuser.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL3VzZXIucnM=) | `0.00% <0.00%> (ø)` | |
   | [core/metadata/src/stm/stream.rs](https://app.codecov.io/gh/apache/iggy/pull/2705?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fstream.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL3N0cmVhbS5ycw==) | `0.00% <0.00%> (ø)` | |
   
   ... and [29 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2705/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org