You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Juan Larriba <jl...@gmail.com> on 2016/03/27 18:03:52 UTC
Re: Review Request 45361: Remove rmdir_tests.cpp from CMake Windows
build
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45361/
-----------------------------------------------------------
(Updated Mar. 27, 2016, 4:03 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Remove rmdir_tests.cpp from CMake Windows build, as it does not compile on Windows. It has been moved to the NOT WIN32 section.
Diffs
-----
"a/C://Users//jlarriba//AppData//Local//Temp//TortoiseGit//CMa4473.tmp//CMakeLists-5e0be20-left.txt" c9d331d
Diff: https://reviews.apache.org/r/45361/diff/
Testing
-------
Correctly built mesos agent on Windows with CMake.
Thanks,
Juan Larriba
Re: Review Request 45361: Remove rmdir_tests.cpp from CMake Windows
build
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45361/#review125569
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On March 27, 2016, 4:03 p.m., Juan Larriba wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45361/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 4:03 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove rmdir_tests.cpp from CMake Windows build, as it does not compile on Windows. It has been moved to the NOT WIN32 section.
>
>
> Diffs
> -----
>
> "a/C://Users//jlarriba//AppData//Local//Temp//TortoiseGit//CMa4473.tmp//CMakeLists-5e0be20-left.txt" c9d331d
>
> Diff: https://reviews.apache.org/r/45361/diff/
>
>
> Testing
> -------
>
> Correctly built mesos agent on Windows with CMake.
>
>
> Thanks,
>
> Juan Larriba
>
>