[GitHub] lebeg commented on a change in pull request #12181: Fixed backwards compatibility checker

[GitBox <gi...@apache.org>]

lebeg commented on a change in pull request #12181: Fixed backwards compatibility checker
URL: https://github.com/apache/incubator-mxnet/pull/12181#discussion_r210300434
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -925,13 +925,23 @@ nightly_test_javascript() {
 nightly_model_backwards_compat_test() {
     set -ex
     export PYTHONPATH=/work/mxnet/python/
+
+    cd /work/venv
+    virtualenv -p python3
+    source /work/venv/bin/activate
 
 Review comment:
   python, python2, python3 are different now, as their corresponding pip, pip2, pip3
   Maybe it would be better to make 2 different virtual env's for python2 and python3. Will try that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services