You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/16 01:59:32 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32867: [SPARK-35721][PYTHON] Path level discover for python unittests
HyukjinKwon commented on a change in pull request #32867:
URL: https://github.com/apache/spark/pull/32867#discussion_r652290250
##########
File path: dev/sparktestsupport/modules.py
##########
@@ -19,10 +19,28 @@
import itertools
import os
import re
+import glob
+
+from sparktestsupport import SPARK_HOME
all_modules = []
+def _discover_python_unittests(paths):
+ if not paths:
+ return set([])
+ tests = set([])
+ pyspark_path = os.path.join(SPARK_HOME, "python")
+ for path in paths:
+ # Discover the test*.py in every path
+ files = glob.glob(os.path.join(pyspark_path, path, "test_*.py"))
+ for f in files:
+ # Convert 'pyspark_path/pyspark/tests/test_abc.py' to 'pyspark.tests.test_abc'
+ file2module = os.path.relpath(f, pyspark_path)[:-3].replace("/", ".")
Review comment:
Hmm .. I like the idea but the implementation is slightly flaky ... e.g.) I wonder if we can import pyspark and go through the sub packages manually instead of going through the files ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org