[GitHub] [beam] ibzib commented on a change in pull request #14056: [BEAM-10961] enable strict dependency checking for sdks/java/io/jms

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #14056:
URL: https://github.com/apache/beam/pull/14056#discussion_r581571536



##########
File path: sdks/java/io/jms/build.gradle
##########
@@ -18,6 +18,7 @@
 
 plugins { id 'org.apache.beam.module' }
 applyJavaNature(
+  enableStrictDependencies:true,

Review comment:
       nit: spacing
   
   ```suggestion
     enableStrictDependencies: true,
   ```

##########
File path: sdks/java/io/jms/build.gradle
##########
@@ -30,14 +31,12 @@ dependencies {
   compile project(path: ":sdks:java:core", configuration: "shadow")
   compile library.java.slf4j_api
   compile library.java.joda_time
-  compile "org.apache.geronimo.specs:geronimo-jms_1.1_spec:1.1.1"

Review comment:
       If nothing changed, please don't move lines around. It makes it harder to trace change history.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org