[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1349: Add new conf kyuubi.frontend.protocols

[GitBox <gi...@apache.org>]

pan3793 commented on a change in pull request #1349:
URL: https://github.com/apache/incubator-kyuubi/pull/1349#discussion_r744681214



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala
##########
@@ -84,8 +86,15 @@ class KyuubiServer(name: String) extends Serverable(name) {
 
   override val backendService: AbstractBackendService = new KyuubiBackendService()
 
-  override val frontendServices: Seq[AbstractFrontendService] = Seq(
-    new KyuubiThriftBinaryFrontendService(this))
+  override lazy val frontendServices: Seq[AbstractFrontendService] =
+    conf.get(FRONTEND_PROTOCOLS).map(FrontendProtocols.withName).map {
+      case THRIFT_BINARY => new KyuubiThriftBinaryFrontendService(this)
+      case REST =>
+        warn("REST frontend protocol is experimental, API may changes in the future.")
+        new RestFrontendService(this)
+      case us =>

Review comment:
       yea, `us` means `unsupported`, I'm fine with `other`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org