You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Cao Manh Dat (JIRA)" <ji...@apache.org> on 2017/08/22 11:33:01 UTC

[jira] [Updated] (SOLR-11276) Refactoring SolrZkClient + ConnectionManager + ConnectionStrategy

     [ https://issues.apache.org/jira/browse/SOLR-11276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cao Manh Dat updated SOLR-11276:
--------------------------------
    Attachment: SOLR-11276.patch

Initial patch, the idea here is to remove SolrZkClient.updateKeeper(SolrZooKeeper keeper) and let SolrZkClient to manage when to close its keeper. 
I also removed DefaultConnectionStrategy, because I think ZkUpdate is complex ( sometime it's hard to know where an Exception will be catched ). ZkClientConnectionStrategy is enough for create new instance of SolrZooKeeper.
[~markrmiller@gmail.com] [~andyetitmoves] [~shalinmangar] what do you think?

> Refactoring SolrZkClient  + ConnectionManager + ConnectionStrategy
> ------------------------------------------------------------------
>
>                 Key: SOLR-11276
>                 URL: https://issues.apache.org/jira/browse/SOLR-11276
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Cao Manh Dat
>         Attachments: SOLR-11276.patch
>
>
> I found OnReconnect mechanism of current SolrZkClient is very hard to follow. I think we should do some refactoring to make it cleaner.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org