You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/28 14:30:22 UTC

[GitHub] [flink] pnowojski commented on pull request #21080: [FLINK-29545][runtime] add netty idle state handler

pnowojski commented on PR #21080:
URL: https://github.com/apache/flink/pull/21080#issuecomment-1295072883

   Hi @zhougit86 , I'm still not sure what's the value of this proposed improvement/fix. It:
   1. adds a bit of complexity to the already pretty complex system
   2. adds a new publicly exposed configuration option, that very very few people will actually know that it exists and even fewer how to use, while we would be forced to maintain forever
   
   Just in order to add built in Flink an unhealthy network detector and print potentially false warning? 🤔 Note that our netty handlers are not non blocking. In some cases, we are doing blocking I/O calls from the netty threads, so the heartbeats can be blocked for non negligible amount of time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org