You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sonal Ojha <so...@sungard.com> on 2014/05/05 12:56:04 UTC
Re: Review Request 18677: CLOUDSTACK-3272
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/
-----------------------------------------------------------
(Updated May 5, 2014, 10:56 a.m.)
Review request for cloudstack, Chiradeep Vittal and Murali Reddy.
Changes
-------
Changes will work on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335.
Bugs: CLOUDSTACK-3272
https://issues.apache.org/jira/browse/CLOUDSTACK-3272
Repository: cloudstack-git
Description
-------
At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
Diffs
-----
server/src/com/cloud/configuration/Config.java 2d55f46
server/src/com/cloud/event/ActionEventUtils.java 00122de
server/src/com/cloud/test/DatabaseConfig.java 9370218
Diff: https://reviews.apache.org/r/18677/diff/
Testing
-------
Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
File Attachments (updated)
----------------
Working patch for master (latest git commit 55f53e13e)
https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
Thanks,
Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review42248
-----------------------------------------------------------
Patch applies, but does not build on master. please resolve check-style errors.
- Murali Reddy
On May 5, 2014, 10:56 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 10:56 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/Config.java 2d55f46
> server/src/com/cloud/event/ActionEventUtils.java 00122de
> server/src/com/cloud/test/DatabaseConfig.java 9370218
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Working patch for master (latest git commit 55f53e13e)
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>
Re: Review Request 18677: CLOUDSTACK-3272
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review42381
-----------------------------------------------------------
Commit 4b89a45e571a34dff0191d501089aa9b1046bc08 in cloudstack's branch refs/heads/master from root
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4b89a45 ]
CLOUDSTACK-3272 Latest changes to add global configuration parameters to control the publishing of events on the message bus
- ASF Subversion and Git Services
On May 6, 2014, 6:53 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 6:53 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd
> engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
> server/src/com/cloud/configuration/Config.java 89f47d4
> server/src/com/cloud/event/ActionEventUtils.java 363bb93
> server/src/com/cloud/event/AlertGenerator.java 5982eea
> server/src/com/cloud/network/IpAddressManagerImpl.java 746221f
> server/src/com/cloud/storage/StorageManagerImpl.java c27a457
> server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d
> server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755
> server/src/com/cloud/test/DatabaseConfig.java 07e4348
> server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b
> server/src/com/cloud/vm/UserVmStateListener.java 6631ca3
> server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Working patch for master (latest git commit 55f53e13e)
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>
Re: Review Request 18677: CLOUDSTACK-3272
Posted by Daan Hoogland <da...@gmail.com>.
Yes, please check the code. It was reverted in 4.4.
On Wed, May 14, 2014 at 12:43 PM, Sonal Ojha <so...@sungard.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
>
> On May 14th, 2014, 8:41 a.m. UTC, *daan Hoogland* wrote:
>
> Sonal, this one didn't make it to 4.4. Can you check it? It would really be nice to have it in.
>
> I dont see these changes made into 4.4.
>
>
> - Sonal
>
> On May 6th, 2014, 6:53 a.m. UTC, Sonal Ojha wrote:
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and
> Murali Reddy.
> By Sonal Ojha.
>
> *Updated May 6, 2014, 6:53 a.m.*
> *Bugs: * CLOUDSTACK-3272<https://issues.apache.org/jira/browse/CLOUDSTACK-3272>
> *Repository: * cloudstack-git
> Description
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
> Testing
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
> Diffs
>
> - engine/components-api/src/com/cloud/event/UsageEventUtils.java
> (f1707bd)
> - engine/components-api/src/com/cloud/network/NetworkStateListener.java
> (0a5e033)
> - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
> (96dafe9)
> - server/src/com/cloud/configuration/Config.java (89f47d4)
> - server/src/com/cloud/event/ActionEventUtils.java (363bb93)
> - server/src/com/cloud/event/AlertGenerator.java (5982eea)
> - server/src/com/cloud/network/IpAddressManagerImpl.java (746221f)
> - server/src/com/cloud/storage/StorageManagerImpl.java (c27a457)
> - server/src/com/cloud/storage/listener/SnapshotStateListener.java
> (45f0c5d)
> - server/src/com/cloud/storage/listener/VolumeStateListener.java
> (1ab2755)
> - server/src/com/cloud/test/DatabaseConfig.java (07e4348)
> - server/src/com/cloud/vm/UserVmManagerImpl.java (dbca21b)
> - server/src/com/cloud/vm/UserVmStateListener.java (6631ca3)
> - server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java
> (e7581d6)
>
> View Diff <https://reviews.apache.org/r/18677/diff/>
> File Attachments
>
> - Working patch for master (latest git commit 55f53e13e)<https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch>
> - Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335<https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch>
>
>
--
Daan
Re: Review Request 18677: CLOUDSTACK-3272
Posted by Sonal Ojha <so...@sungard.com>.
> On May 14, 2014, 8:41 a.m., daan Hoogland wrote:
> > Sonal, this one didn't make it to 4.4. Can you check it? It would really be nice to have it in.
I dont see these changes made into 4.4.
- Sonal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review42951
-----------------------------------------------------------
On May 6, 2014, 6:53 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 6:53 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd
> engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
> server/src/com/cloud/configuration/Config.java 89f47d4
> server/src/com/cloud/event/ActionEventUtils.java 363bb93
> server/src/com/cloud/event/AlertGenerator.java 5982eea
> server/src/com/cloud/network/IpAddressManagerImpl.java 746221f
> server/src/com/cloud/storage/StorageManagerImpl.java c27a457
> server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d
> server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755
> server/src/com/cloud/test/DatabaseConfig.java 07e4348
> server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b
> server/src/com/cloud/vm/UserVmStateListener.java 6631ca3
> server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Working patch for master (latest git commit 55f53e13e)
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>
Re: Review Request 18677: CLOUDSTACK-3272
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review42951
-----------------------------------------------------------
Sonal, this one didn't make it to 4.4. Can you check it? It would really be nice to have it in.
- daan Hoogland
On May 6, 2014, 6:53 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 6:53 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd
> engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
> server/src/com/cloud/configuration/Config.java 89f47d4
> server/src/com/cloud/event/ActionEventUtils.java 363bb93
> server/src/com/cloud/event/AlertGenerator.java 5982eea
> server/src/com/cloud/network/IpAddressManagerImpl.java 746221f
> server/src/com/cloud/storage/StorageManagerImpl.java c27a457
> server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d
> server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755
> server/src/com/cloud/test/DatabaseConfig.java 07e4348
> server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b
> server/src/com/cloud/vm/UserVmStateListener.java 6631ca3
> server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Working patch for master (latest git commit 55f53e13e)
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>
Re: Review Request 18677: CLOUDSTACK-3272
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review42383
-----------------------------------------------------------
Ship it!
commit 4b89a45e571a34dff0191d501089aa9b1046bc08 in master
- Murali Reddy
On May 6, 2014, 6:53 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 6:53 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd
> engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
> server/src/com/cloud/configuration/Config.java 89f47d4
> server/src/com/cloud/event/ActionEventUtils.java 363bb93
> server/src/com/cloud/event/AlertGenerator.java 5982eea
> server/src/com/cloud/network/IpAddressManagerImpl.java 746221f
> server/src/com/cloud/storage/StorageManagerImpl.java c27a457
> server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d
> server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755
> server/src/com/cloud/test/DatabaseConfig.java 07e4348
> server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b
> server/src/com/cloud/vm/UserVmStateListener.java 6631ca3
> server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Working patch for master (latest git commit 55f53e13e)
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>
Re: Review Request 18677: CLOUDSTACK-3272
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review44511
-----------------------------------------------------------
Commit eb8e630f24f5359b6c2e9a74bf12ea338df66a41 in cloudstack's branch refs/heads/master from Rohit Yadav
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eb8e630 ]
AlertGenerator: Fix NPE from CLOUDSTACK-3272
There was a commit 4b89a45e571a34dff0191d501089aa9b1046bc08 on master which was
added by "root@devcloud.apache.org" with no committer signature so I cannot tell
whom to reach. In the code it looks like they forgot to initialize the static
config dao variable which is causing NPE on master. The fix simply initializes
the s_configDao with injected configDao object.
Signed-off-by: Rohit Yadav <bh...@apache.org>
- ASF Subversion and Git Services
On May 6, 2014, 6:53 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 6:53 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd
> engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
> server/src/com/cloud/configuration/Config.java 89f47d4
> server/src/com/cloud/event/ActionEventUtils.java 363bb93
> server/src/com/cloud/event/AlertGenerator.java 5982eea
> server/src/com/cloud/network/IpAddressManagerImpl.java 746221f
> server/src/com/cloud/storage/StorageManagerImpl.java c27a457
> server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d
> server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755
> server/src/com/cloud/test/DatabaseConfig.java 07e4348
> server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b
> server/src/com/cloud/vm/UserVmStateListener.java 6631ca3
> server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Working patch for master (latest git commit 55f53e13e)
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>
Re: Review Request 18677: CLOUDSTACK-3272
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review42470
-----------------------------------------------------------
Commit 882bf079fa1886c9feab0948066a02c1cb6cd86a in cloudstack's branch refs/heads/4.4 from sonal.ojha
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=882bf07 ]
CLOUDSTACK-3272 Fixing NullPointerException for alerts
Signed-off-by: Daan Hoogland <da...@onecht.net>
- ASF Subversion and Git Services
On May 6, 2014, 6:53 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 6:53 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd
> engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
> server/src/com/cloud/configuration/Config.java 89f47d4
> server/src/com/cloud/event/ActionEventUtils.java 363bb93
> server/src/com/cloud/event/AlertGenerator.java 5982eea
> server/src/com/cloud/network/IpAddressManagerImpl.java 746221f
> server/src/com/cloud/storage/StorageManagerImpl.java c27a457
> server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d
> server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755
> server/src/com/cloud/test/DatabaseConfig.java 07e4348
> server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b
> server/src/com/cloud/vm/UserVmStateListener.java 6631ca3
> server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Working patch for master (latest git commit 55f53e13e)
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>
Re: Review Request 18677: CLOUDSTACK-3272
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review42566
-----------------------------------------------------------
Commit 703e9f6f46228518e9ac83efe66cdfebe9107400 in cloudstack's branch refs/heads/4.4 from Daan Hoogland
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=703e9f6 ]
Revert "CLOUDSTACK-3272 Fixing NullPointerException for alerts"
This reverts commit 882bf079fa1886c9feab0948066a02c1cb6cd86a.
- ASF Subversion and Git Services
On May 6, 2014, 6:53 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 6:53 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd
> engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
> server/src/com/cloud/configuration/Config.java 89f47d4
> server/src/com/cloud/event/ActionEventUtils.java 363bb93
> server/src/com/cloud/event/AlertGenerator.java 5982eea
> server/src/com/cloud/network/IpAddressManagerImpl.java 746221f
> server/src/com/cloud/storage/StorageManagerImpl.java c27a457
> server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d
> server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755
> server/src/com/cloud/test/DatabaseConfig.java 07e4348
> server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b
> server/src/com/cloud/vm/UserVmStateListener.java 6631ca3
> server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Working patch for master (latest git commit 55f53e13e)
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>
Re: Review Request 18677: CLOUDSTACK-3272
Posted by Sonal Ojha <so...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/
-----------------------------------------------------------
(Updated May 6, 2014, 6:53 a.m.)
Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy.
Bugs: CLOUDSTACK-3272
https://issues.apache.org/jira/browse/CLOUDSTACK-3272
Repository: cloudstack-git
Description
-------
At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
Diffs (updated)
-----
engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd
engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
server/src/com/cloud/configuration/Config.java 89f47d4
server/src/com/cloud/event/ActionEventUtils.java 363bb93
server/src/com/cloud/event/AlertGenerator.java 5982eea
server/src/com/cloud/network/IpAddressManagerImpl.java 746221f
server/src/com/cloud/storage/StorageManagerImpl.java c27a457
server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d
server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755
server/src/com/cloud/test/DatabaseConfig.java 07e4348
server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b
server/src/com/cloud/vm/UserVmStateListener.java 6631ca3
server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6
Diff: https://reviews.apache.org/r/18677/diff/
Testing
-------
Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
File Attachments
----------------
Working patch for master (latest git commit 55f53e13e)
https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
Thanks,
Sonal Ojha
Re: Review Request 18677: CLOUDSTACK-3272
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review42154
-----------------------------------------------------------
File Attachment: Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335 - 0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
<https://reviews.apache.org//r/18677/#fcomment6>
can you use update diff instead of making attachements? This helps reviewing updates.
- daan Hoogland
On May 5, 2014, 10:56 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 10:56 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action events,usage events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to introduce global setting config parameters to specify which category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/Config.java 2d55f46
> server/src/com/cloud/event/ActionEventUtils.java 00122de
> server/src/com/cloud/test/DatabaseConfig.java 9370218
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Working patch for master (latest git commit 55f53e13e)
> https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
> https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>