You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/10/24 18:35:33 UTC

[jira] [Commented] (CURATOR-140) Support the initial data for the node in InterProcessReadWriteLock

    [ https://issues.apache.org/jira/browse/CURATOR-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183018#comment-14183018 ] 

ASF GitHub Bot commented on CURATOR-140:
----------------------------------------

GitHub user brienwheeler-sqrrl opened a pull request:

    https://github.com/apache/curator/pull/48

    CURATOR-140: Allow InterProcessReadWriteLock consumer to set lock node d...

    Simple change to plumb through the ability to set node data from the consumer of InterProcessReadWriteLock.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sqrrldata/curator CURATOR-140

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit 77a1afbcc074d9ef87ba3bfc7d3cb641ad2f727e
Author: Brien Wheeler <br...@briens-macbook-pro.local>
Date:   2014-10-24T16:33:16Z

    CURATOR-140: Allow InterProcessReadWriteLock consumer to set lock node data.

----


> Support the initial data for the node in InterProcessReadWriteLock
> ------------------------------------------------------------------
>
>                 Key: CURATOR-140
>                 URL: https://issues.apache.org/jira/browse/CURATOR-140
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Recipes
>            Reporter: Azrael
>            Priority: Minor
>
> Currently, locks(writeLock, readLock) in InterProcessReadWriteLock use the InetAddress for a initial data for the node, It is a little difficult to debug the lock owner as it shows only IP. If the initial data for lock node can be set, participantNodes contains the given information(hostname, id). So, it is easy  to debug participantNodes.
> {code}
> writeLock = InterProcessReadWriteLock.writeLock();
> Collection<String> nodes = writeLock.getParticipantNodes();
> for (String node: nodes) {
>     String nodeData = new String(client.getData().forPath(node));
> }
> {code} 
> {{nodeData}} should be the information which is given in argument.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)