You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangjiaochun <gi...@git.apache.org> on 2018/12/06 11:18:55 UTC
[GitHub] spark pull request #23246: [SPARK-26292][CORE]Assert statement of currentPag...
GitHub user wangjiaochun opened a pull request:
https://github.com/apache/spark/pull/23246
[SPARK-26292][CORE]Assert statement of currentPage may be not in right place
## What changes were proposed in this pull request?
The assert statement of currentPage is not in right place，it should be add to the back of
allocatePage in a function acquireNewPageIfNecessary.
## How was this patch tested?
Existing tests
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangjiaochun/spark SorterPagePointer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23246
----
commit 877cf4cf8d2a0f3c6868980eabaa41b5ee20767b
Author: 10087686 <wa...@...>
Date: 2018-12-06T10:49:49Z
assert place is not right
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23246: [SPARK-26292][CORE]Assert statement of currentPage may b...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23246
Ditto. Let's close these and focus on fixing actual bugs.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23246: [SPARK-26292][CORE]Assert statement of currentPage may b...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23246
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23246: [SPARK-26292][CORE]Assert statement of currentPag...
Posted by wangjiaochun <gi...@git.apache.org>.
Github user wangjiaochun closed the pull request at:
https://github.com/apache/spark/pull/23246
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23246: [SPARK-26292][CORE]Assert statement of currentPage may b...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23246
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23246: [SPARK-26292][CORE]Assert statement of currentPage may b...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23246
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23246: [SPARK-26292][CORE]Assert statement of currentPage may b...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23246
It's not clear this is where it should be from the description. Please review https://spark.apache.org/contributing.html This one should be closed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org