You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/24 03:24:30 UTC

[GitHub] [inlong] thesumery commented on a diff in pull request #4765: [INLONG-4763][Sort] Import sort end2end unit test with sql file input

thesumery commented on code in PR #4765:
URL: https://github.com/apache/inlong/pull/4765#discussion_r905686214


##########
inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/parser/result/FlinkSqlParseResult.java:
##########
@@ -58,7 +58,7 @@ public FlinkSqlParseResult(TableEnvironment tableEnv, List<String> createTableSq
     @Override
     public void execute() throws Exception {
         executeCreateTableSqls(createTableSqls);
-        executeLoadSqls(loadSqls).await();
+        executeLoadSqls(loadSqls);

Review Comment:
   Once in testcontainer. `jobManager.execInContainer("bash", "-c", "flink run -d -c org.apache.inlong.sort.Entrance /tmp/sort-dist.jar  --lightweight true --sql.script.file /tmp/kafka.sql");` will await commnd finish, but because awit, it will never compelete.
   The reason for this design before is to facilitate testing，so once we want test in IDEA, add `await`, and we commit code we delete `await`.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org