[GitHub] [incubator-superset] riahk commented on a change in pull request #12053: feat(alerts/reports): delete and bulk delete actions

[GitBox <gi...@apache.org>]

riahk commented on a change in pull request #12053:
URL: https://github.com/apache/incubator-superset/pull/12053#discussion_r543692347



##########
File path: superset-frontend/src/views/CRUD/alert/types.ts
##########
@@ -52,7 +52,7 @@ export type AlertObject = {
   database?: MetaObject;
   description?: string;
   grace_period?: number;
-  id?: number;
+  id: number;

Review comment:
       Does this not throw a ts error when creating alerts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org