[GitHub] [samza] lhaiesp commented on a change in pull request #950: SAMZA-2126: Bug fixes for batch-mode generated stream specs

[GitBox <gi...@apache.org>]

lhaiesp commented on a change in pull request #950: SAMZA-2126: Bug fixes for batch-mode generated stream specs
URL: https://github.com/apache/samza/pull/950#discussion_r264499493
 
 

 ##########
 File path: samza-core/src/test/java/org/apache/samza/execution/TestStreamEdge.java
 ##########
 @@ -50,8 +50,9 @@ public void testGetStreamSpec_Batch() {
     Map<String, String> config = new HashMap<>();
     config.put(ApplicationConfig.APP_MODE, ApplicationConfig.ApplicationMode.BATCH.name());
     config.put(ApplicationConfig.APP_RUN_ID, "123");
-    StreamEdge edge = new StreamEdge(spec, true, false, new MapConfig(config));
-    assertEquals(edge.getStreamSpec().getPhysicalName(), spec.getPhysicalName() + "-123");
+    StreamSpec batchSpec = new StreamSpec("stream-1", "stream-1", "system-1");
+    StreamEdge edge = new StreamEdge(batchSpec, true, false, new MapConfig(config));
+    assertEquals(edge.getStreamSpec().getPhysicalName(), batchSpec.getPhysicalName() + "-123");
 
 Review comment:
   shouldn't you have another test case where the run.id is already applied and you verify it's not re-applied?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services