You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by bt...@apache.org on 2022/03/15 02:00:19 UTC

[james-project] 01/10: JAMES-3720 Fix temporary file leak in email reprocessing

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch 3.7.x
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit d8d66f63d0521b50e0e05a3e7e7f9a8d8ec69bca
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Fri Mar 4 16:57:37 2022 +0700

    JAMES-3720 Fix temporary file leak in email reprocessing
    
    (cherry picked from commit 4c31277b665368688c70336cb77a960becd7881c)
---
 .../java/org/apache/james/webadmin/service/ReprocessingService.java    | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/server/protocols/webadmin/webadmin-mailrepository/src/main/java/org/apache/james/webadmin/service/ReprocessingService.java b/server/protocols/webadmin/webadmin-mailrepository/src/main/java/org/apache/james/webadmin/service/ReprocessingService.java
index 35f3626..5b7ed6b 100644
--- a/server/protocols/webadmin/webadmin-mailrepository/src/main/java/org/apache/james/webadmin/service/ReprocessingService.java
+++ b/server/protocols/webadmin/webadmin-mailrepository/src/main/java/org/apache/james/webadmin/service/ReprocessingService.java
@@ -28,6 +28,7 @@ import javax.inject.Inject;
 import javax.mail.MessagingException;
 
 import org.apache.commons.lang3.tuple.Pair;
+import org.apache.james.lifecycle.api.LifecycleUtil;
 import org.apache.james.mailrepository.api.MailKey;
 import org.apache.james.mailrepository.api.MailRepository;
 import org.apache.james.mailrepository.api.MailRepositoryPath;
@@ -68,6 +69,8 @@ public class ReprocessingService {
                 repository.remove(mail);
             } catch (Exception e) {
                 throw new RuntimeException("Error encountered while reprocessing mail " + mail.getName(), e);
+            } finally {
+                LifecycleUtil.dispose(mail);
             }
         }
 

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org