You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "sanjanagoyal (via GitHub)" <gi...@apache.org> on 2023/05/23 12:45:17 UTC
[GitHub] [kafka] sanjanagoyal opened a new pull request, #13746: removed recreation of partition to fix partitions having uneven data disctribution
sanjanagoyal opened a new pull request, #13746:
URL: https://github.com/apache/kafka/pull/13746
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13746: removed recreation of partition to fix partitions having uneven data disctribution
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13746:
URL: https://github.com/apache/kafka/pull/13746#issuecomment-1689229303
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13746: removed recreation of partition to fix partitions having uneven data disctribution
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13746:
URL: https://github.com/apache/kafka/pull/13746#issuecomment-1560684188
Hey @sanjanagoyal
Thank you for your first contribution to the project.
1. Would you please add a unit test that fails prior to this change and succeeds afterwards? Apart from ensuring that this bug doesn't occur again, it also helps the reviewers understand the nature of the bug and the fix.
2. I would also suggest to open a JIRA describing the bug and associate this PR with the JIRA. You can find further instructions on how to do so at https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org