You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/23 02:54:12 UTC
[GitHub] [arrow] GregBowyer opened a new pull request #8993: ARROW-10943: [Rust][Parquet] Always init new RleDecoder
GregBowyer opened a new pull request #8993:
URL: https://github.com/apache/arrow/pull/8993
Part of the removal of specialisation makes the RleDecoder remain
instanticated. This is done to lose some allocations but right now
appears to leave a decoder in a semi configured state that can mis-read
RLE packed data.
As such we just init a new one each time the parent decoder has data set
on it in a fashion to the pre refactored code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8993: ARROW-10943: [Rust][Parquet] Always init new RleDecoder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8993:
URL: https://github.com/apache/arrow/pull/8993#issuecomment-749899506
https://issues.apache.org/jira/browse/ARROW-10943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #8993: ARROW-10943: [Rust][Parquet] Always init new RleDecoder
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #8993:
URL: https://github.com/apache/arrow/pull/8993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8993: ARROW-10943: [Rust][Parquet] Always init new RleDecoder
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8993:
URL: https://github.com/apache/arrow/pull/8993#issuecomment-750881671
@GregBowyer -- yes I definitely think whatever is wrong here is very dependent on memory layout, os, whatever.
I have filed https://issues.apache.org/jira/browse/ARROW-11027 to keep on tracking down the error.
I'll try some of the code in #8498 to see if perhaps that is the final piece of the puzzle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #8993: ARROW-10943: [Rust][Parquet] Always init new RleDecoder
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #8993:
URL: https://github.com/apache/arrow/pull/8993#issuecomment-749980403
Looks good. Could we add a test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] GregBowyer commented on pull request #8993: ARROW-10943: [Rust][Parquet] Always init new RleDecoder
Posted by GitBox <gi...@apache.org>.
GregBowyer commented on pull request #8993:
URL: https://github.com/apache/arrow/pull/8993#issuecomment-750457279
The panic I might need some help with. The instructions above dont give me any crash for several hours. Could it be OS, platform ,cpu related (see #8948 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #8993: ARROW-10943: [Rust][Parquet] Always init new RleDecoder
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8993:
URL: https://github.com/apache/arrow/pull/8993#issuecomment-749903578
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8993?src=pr&el=h1) Report
> Merging [#8993](https://codecov.io/gh/apache/arrow/pull/8993?src=pr&el=desc) (17055ca) into [master](https://codecov.io/gh/apache/arrow/commit/0519c4c0ecccd7d84ce44bd3a3e7bcb4fef8f4d6?el=desc) (0519c4c) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/8993?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8993 +/- ##
=======================================
Coverage 82.64% 82.64%
=======================================
Files 200 200
Lines 49730 49731 +1
=======================================
+ Hits 41098 41099 +1
Misses 8632 8632
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8993?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/encodings/decoding.rs](https://codecov.io/gh/apache/arrow/pull/8993/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZGVjb2RpbmcucnM=) | `92.85% <100.00%> (+0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8993?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8993?src=pr&el=footer). Last update [081728f...17055ca](https://codecov.io/gh/apache/arrow/pull/8993?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] GregBowyer commented on pull request #8993: ARROW-10943: [Rust][Parquet] Always init new RleDecoder
Posted by GitBox <gi...@apache.org>.
GregBowyer commented on pull request #8993:
URL: https://github.com/apache/arrow/pull/8993#issuecomment-750452426
The test would need clearning up, and I wonder if it should be ported to proptest which would do the same thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org