You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2023/01/19 02:47:07 UTC
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4162: fix issue #4057
bowenliang123 commented on code in PR #4162:
URL: https://github.com/apache/kyuubi/pull/4162#discussion_r1080757134
##########
bin/docker-image-tool.sh:
##########
@@ -227,8 +227,8 @@ Examples:
EOF
}
-# shellcheck disable=SC2199
-if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
+
Review Comment:
remove the used blank line.
##########
bin/kyuubi:
##########
@@ -30,8 +30,8 @@ function usage() {
echo " -h | --help - Show this help message"
}
-# shellcheck disable=SC2199
-if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
+
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org