You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/06/08 07:50:22 UTC
[royale-asjs] branch develop updated: Add BrowserResizeListener to
use at component level,
rename old one to "BrowserResizeApplicationListener" to indicate that its
use must be only at Application level. This way we can get better
performance if setting the listener just at the component level we need and
not at app level.
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new a69d939 Add BrowserResizeListener to use at component level, rename old one to "BrowserResizeApplicationListener" to indicate that its use must be only at Application level. This way we can get better performance if setting the listener just at the component level we need and not at app level.
a69d939 is described below
commit a69d939ea7e6502e444d3f9875a8e7637dcca373
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Mon Jun 8 09:50:11 2020 +0200
Add BrowserResizeListener to use at component level, rename old one to "BrowserResizeApplicationListener" to indicate that its use must be only at Application level. This way we can get better performance if setting the listener just at the component level we need and not at app level.
---
.../Basic/src/main/resources/basic-manifest.xml | 1 +
.../apache/royale/core/BrowserResizeListener.as | 78 ++++++++++++++++++++++
.../Core/src/main/resources/basic-manifest.xml | 2 +-
...ener.as => BrowserResizeApplicationListener.as} | 6 +-
4 files changed, 83 insertions(+), 4 deletions(-)
diff --git a/frameworks/projects/Basic/src/main/resources/basic-manifest.xml b/frameworks/projects/Basic/src/main/resources/basic-manifest.xml
index caf9eff..a666835 100644
--- a/frameworks/projects/Basic/src/main/resources/basic-manifest.xml
+++ b/frameworks/projects/Basic/src/main/resources/basic-manifest.xml
@@ -21,6 +21,7 @@
<componentPackage>
+ <component id="BrowserResizeListener" class="org.apache.royale.core.BrowserResizeListener"/>
<component id="Application" class="org.apache.royale.core.Application"/>
<component id="AirApplication" class="org.apache.royale.core.AirApplication"/>
<component id="View" class="org.apache.royale.core.View"/>
diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/core/BrowserResizeListener.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/core/BrowserResizeListener.as
new file mode 100644
index 0000000..632fa69
--- /dev/null
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/core/BrowserResizeListener.as
@@ -0,0 +1,78 @@
+////////////////////////////////////////////////////////////////////////////////
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+package org.apache.royale.core
+{
+ import org.apache.royale.core.UIBase;
+ import org.apache.royale.events.Event;
+ import org.apache.royale.utils.sendStrandEvent;
+
+ /**
+ * The BrowserResizeListener class listens for browser
+ * resizing and resizes the component accordingly.
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.10.0
+ */
+ public class BrowserResizeListener extends Bead
+ {
+ /**
+ * Constructor.
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.10.0
+ */
+ public function BrowserResizeListener()
+ {
+ }
+
+ /**
+ * @copy org.apache.royale.core.IBead#strand
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.10.0
+ */
+ override public function set strand(value:IStrand):void
+ {
+ super.strand = value as UIBase;
+
+ COMPILE::SWF
+ {
+ // TODO
+ }
+ COMPILE::JS
+ {
+ window.addEventListener('resize', this.resizeHandler, false);
+ }
+ }
+
+ /**
+ * Make the strand send "sizeChanged" event when browser is resized
+ */
+ private function resizeHandler(event:Event):void
+ {
+ sendStrandEvent(_strand, 'sizeChanged');
+ }
+ }
+}
diff --git a/frameworks/projects/Core/src/main/resources/basic-manifest.xml b/frameworks/projects/Core/src/main/resources/basic-manifest.xml
index b887389..de86ae7 100644
--- a/frameworks/projects/Core/src/main/resources/basic-manifest.xml
+++ b/frameworks/projects/Core/src/main/resources/basic-manifest.xml
@@ -26,7 +26,7 @@
<component id="CSSFontFaceBead" class="org.apache.royale.core.CSSFontFaceBead" />
<component id="EventLoggingBead" class="org.apache.royale.core.EventLoggingBead" />
<component id="BrowserScroller" class="org.apache.royale.core.BrowserScroller"/>
- <component id="BrowserResizeListener" class="org.apache.royale.core.BrowserResizeListener"/>
+ <component id="BrowserResizeApplicationListener" class="org.apache.royale.core.BrowserResizeApplicationListener"/>
<component id="BrowserOrientation" class="org.apache.royale.core.BrowserOrientation"/>
<component id="SimpleValuesImpl" class="org.apache.royale.core.SimpleValuesImpl"/>
<component id="SimpleStatesImpl" class="org.apache.royale.core.SimpleStatesImpl"/>
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/BrowserResizeListener.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/BrowserResizeApplicationListener.as
similarity index 96%
rename from frameworks/projects/Core/src/main/royale/org/apache/royale/core/BrowserResizeListener.as
rename to frameworks/projects/Core/src/main/royale/org/apache/royale/core/BrowserResizeApplicationListener.as
index 5d61288..052fb56 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/BrowserResizeListener.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/BrowserResizeApplicationListener.as
@@ -31,7 +31,7 @@ COMPILE::JS
}
/**
- * The BrowserResizeListener class listens for browser
+ * The BrowserResizeApplicationListener class listens for browser
* resizing and resizes the application accordingly.
*
* @langversion 3.0
@@ -39,7 +39,7 @@ COMPILE::JS
* @playerversion AIR 2.6
* @productversion Royale 0.8
*/
- public class BrowserResizeListener implements IBead
+ public class BrowserResizeApplicationListener implements IBead
{
/**
* Constructor.
@@ -49,7 +49,7 @@ COMPILE::JS
* @playerversion AIR 2.6
* @productversion Royale 0.8
*/
- public function BrowserResizeListener()
+ public function BrowserResizeApplicationListener()
{
}