You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/10 20:59:27 UTC

[GitHub] [arrow-datafusion] andygrove opened a new issue, #2505: Ballista assumes all aggregate expressions are not DISTINCT

andygrove opened a new issue, #2505:
URL: https://github.com/apache/arrow-datafusion/issues/2505

   **Describe the bug**
   We have a hard-coded `distinct = false` parameter in `ballista/rust/core/src/serde/physical_plan/mod.rs`.
   
   ``` rust
   Ok(create_aggregate_expr(
       &aggr_function.into(),
       false, // <-- hard-coded "distinct"
       input_phy_expr.as_slice(),
       &physical_schema,
       name.to_string(),
   )?)
   ```
   
   **To Reproduce**
   Try running a `COUNT(DISTINCT expr)` in Ballista
   
   **Expected behavior**
   We need to include the distinct flag in the protobuf for aggregate queries and implement the appropriate serde code.
   
   **Additional context**
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] comphead commented on issue #2505: Ballista assumes all aggregate expressions are not DISTINCT

Posted by GitBox <gi...@apache.org>.
comphead commented on issue #2505:
URL: https://github.com/apache/arrow-datafusion/issues/2505#issuecomment-1125013122

   I checked the backtrace 
   ```
      2: datafusion_physical_expr::aggregate::build_in::create_aggregate_expr
                at ./datafusion/physical-expr/src/aggregate/build_in.rs:75:13
      3: datafusion::physical_plan::planner::create_aggregate_expr_with_name
                at ./datafusion/core/src/physical_plan/planner.rs:1347:13
      4: datafusion::physical_plan::planner::create_aggregate_expr
                at ./datafusion/core/src/physical_plan/planner.rs:1390:5
      5: datafusion::physical_plan::planner::DefaultPhysicalPlanner::create_initial_plan::{{closure}}::{{closure}}
                at ./datafusion/core/src/physical_plan/planner.rs:525:29
   ```
   
   I didn't notice ballista modules here. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] comphead commented on issue #2505: Ballista assumes all aggregate expressions are not DISTINCT

Posted by GitBox <gi...@apache.org>.
comphead commented on issue #2505:
URL: https://github.com/apache/arrow-datafusion/issues/2505#issuecomment-1124992211

   Hi @andygrove Ive run in local ballista
   ```
   SELECT count(distinct c1) as cnt_distinct FROM aggregate_test_100
   ```
   
   And the result is expected
   ```
   +--------------+
   | cnt_distinct |
   +--------------+
   | 5            |
   +--------------+
   ```
   which is expected


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org