You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/01/15 18:42:06 UTC
Re: Review Request 41617: Enabled whitespace-comments category in
mesos-style.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41617/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 5:42 p.m.)
Review request for mesos and Michael Park.
Summary (updated)
-----------------
Enabled whitespace-comments category in mesos-style.py
Bugs: MESOS-4231
https://issues.apache.org/jira/browse/MESOS-4231
Repository: mesos
Description
-------
Enabled whitespace-comments category in mesos-style.py
Diffs
-----
support/cpplint.py 6890e27f92603b025e25e4db01decf351c33c9a1
support/mesos-style.py 5ee17593153df7815426918a1da6e25cb1188bca
Diff: https://reviews.apache.org/r/41617/diff/
Testing
-------
Ran the support/mesos-styles.py after this change and found zero errors.
Tried a commit for the following patch:
diff --git a/src/tests/slave_tests.cpp b/src/tests/slave_tests.cpp
index eb47b53..e579d20 100644
--- a/src/tests/slave_tests.cpp
+++ b/src/tests/slave_tests.cpp
@@ -2228,7 +2228,7 @@ TEST_F(SlaveTest, DiscoveryInfoAndPorts)
AWAIT_READY(launchTask);
- // Verify label key and value in slave state.json.
+ //Verify label key and value in slave state.json.
Future<process::http::Response> response =
process::http::get(slave.get(), "state.json");
And the git commit hook correctly failed it:
$ git commit -m "test"
Checking 1 files
src/tests/slave_tests.cpp:2231: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 1
Thanks,
Avinash sridharan
Re: Review Request 41617: Enabled whitespace-comments category in
mesos-style.py
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41617/#review114811
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Jan. 15, 2016, 5:42 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41617/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 5:42 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4231
> https://issues.apache.org/jira/browse/MESOS-4231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled whitespace-comments category in mesos-style.py
>
>
> Diffs
> -----
>
> support/cpplint.py 6890e27f92603b025e25e4db01decf351c33c9a1
> support/mesos-style.py 5ee17593153df7815426918a1da6e25cb1188bca
>
> Diff: https://reviews.apache.org/r/41617/diff/
>
>
> Testing
> -------
>
> Ran the support/mesos-styles.py after this change and found zero errors.
>
> Tried a commit for the following patch:
> diff --git a/src/tests/slave_tests.cpp b/src/tests/slave_tests.cpp
> index eb47b53..e579d20 100644
> --- a/src/tests/slave_tests.cpp
> +++ b/src/tests/slave_tests.cpp
> @@ -2228,7 +2228,7 @@ TEST_F(SlaveTest, DiscoveryInfoAndPorts)
>
> AWAIT_READY(launchTask);
>
> - // Verify label key and value in slave state.json.
> + //Verify label key and value in slave state.json.
> Future<process::http::Response> response =
> process::http::get(slave.get(), "state.json");
>
> And the git commit hook correctly failed it:
> $ git commit -m "test"
> Checking 1 files
> src/tests/slave_tests.cpp:2231: Should have a space between // and comment [whitespace/comments] [4]
> Total errors found: 1
>
>
> Thanks,
>
> Avinash sridharan
>
>