You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/10 13:34:29 UTC
[GitHub] [pulsar] ltamber opened a new pull request #7234: get lookup permission error
ltamber opened a new pull request #7234:
URL: https://github.com/apache/pulsar/pull/7234
### Motivation
Currently，when pulsar AuthorizationService check lookup permission, if the role canProducer **or** canConsumer mean that canLookup, but actually in the code https://github.com/apache/pulsar/blob/master/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationService.java#L267, if the method canProduce or canConsume throw exception, `canLookup` will just throw the exception and won't check the other permission.
### Modification
invoke `canLookupAsync` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7234: get lookup permission error
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7234:
URL: https://github.com/apache/pulsar/pull/7234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ltamber commented on pull request #7234: get lookup permission error
Posted by GitBox <gi...@apache.org>.
ltamber commented on pull request #7234:
URL: https://github.com/apache/pulsar/pull/7234#issuecomment-642374220
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ltamber commented on pull request #7234: get lookup permission error
Posted by GitBox <gi...@apache.org>.
ltamber commented on pull request #7234:
URL: https://github.com/apache/pulsar/pull/7234#issuecomment-642415092
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org