You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Willy Lulciuc (JIRA)" <ji...@apache.org> on 2018/02/22 06:46:00 UTC

[jira] [Commented] (BEAM-3664) Port SolrIOTest off DoFnTester

    [ https://issues.apache.org/jira/browse/BEAM-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372481#comment-16372481 ] 

Willy Lulciuc commented on BEAM-3664:
-------------------------------------

[~kenn]: Replacing DoFnTester with PipelineTest in testWriteWithMaxBatchSize() is not as straight forward here (at least it certainly would seem). Let me explain why. The test has the following comment:

"write bundles size is the runner decision, we cannot force a bundle size, so we test the Writer as a DoFn outside of a runner."

Meaning, DoFnTester.of() is used to invoke processElement() as the Solr documents are iterated over, with periodic calls to commit documents, then check insertion counters, etc.

I've tried a couples ways. But none providing the convenience of DoFnTester.of() to compare the number inserted vs processed.

Am I missing something?

 

 

 

> Port SolrIOTest off DoFnTester
> ------------------------------
>
>                 Key: BEAM-3664
>                 URL: https://issues.apache.org/jira/browse/BEAM-3664
>             Project: Beam
>          Issue Type: Sub-task
>          Components: io-java-solr
>            Reporter: Kenneth Knowles
>            Priority: Major
>              Labels: beginner, newbie, starter
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)