You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/07/07 05:38:42 UTC

[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

rohityadavcloud opened a new pull request, #6536:
URL: https://github.com/apache/cloudstack/pull/6536

   Fixes #6533
   
   This adds the option returned in API which in turn shows the option and possible values in the UI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

harikrishna-patnala commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1177232284

   Changes wrt PR looks good and I can see the "nicAdapter" from VM settings. When I change/set the nicAdapter the interface is set accordingly on the VM.
   
   One observation I've made with the "rootDiskController" during this testing is,
   If rootDiskController is changed to "ide" then it is not reflected on VM. 
   @sureshanaparti do you think it's an issue to be fixed, not in this PR but as a separate one.
   
   cc @rohityadavcloud @GabrielBrascher @weizhouapache any suggestion here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

Pearl1594 commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1177254416

   @harikrishna-patnala wrt to rootdiskcontroller setting, if the root disk and data disk controller settings are already defined on the template, then they take precedence over the setting on the VM - PR: https://github.com/apache/cloudstack/pull/6276 attempts to fix that anomaly. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

rohityadavcloud commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1177291343

   Thanks for review/testing @harikrishna-patnala @Pearl1594 @sureshanaparti 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud merged pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

rohityadavcloud merged PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1177138948

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3721


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

rohityadavcloud commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1177101024

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1178016704

   <b>Trillian test result (tid-4438)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40428 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6536-t4438-kvm-centos7.zip
   Smoke tests completed. 97 look OK, 1 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_kvm_host_degraded | `Error` | 666.05 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1177102046

   @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

sonarcloud[bot] commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1177148148

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6536)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6536&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6536&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6536&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6536&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6536&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6536&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6536&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6536&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6536&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6536&resolved=false&types=CODE_SMELL) [![D](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/D-16px.png 'D')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6536&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6536&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6536&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6536&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6536&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6536&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1177144389

   @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6536: kvm: add support nicAdapter detail for vm and template settings for KVM

Posted by GitBox <gi...@apache.org>.

rohityadavcloud commented on PR #6536:
URL: https://github.com/apache/cloudstack/pull/6536#issuecomment-1177143932

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org