[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5967: Minor: Add Expr::between and clean up boilerplate

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5967:
URL: https://github.com/apache/arrow-datafusion/pull/5967#discussion_r1163244458


##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -1013,20 +1012,12 @@ mod test {
 
     #[test]
     fn between_case() -> Result<()> {
-        let expr = Expr::Between(Between::new(
-            Box::new(col("a")),
-            false,
-            Box::new(Expr::Literal(Utf8(Some("2002-05-08".to_string())))),
+        let expr = col("a").between(

Review Comment:
   I think this is easier to understand what is happening



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org