You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wido <gi...@git.apache.org> on 2015/12/11 15:08:11 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1220
CLOUDSTACK-9141: Validate userdata for valid base64
This prevents the userdata from going through the stack completely
and finding out very late in the process that it is invalid data.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wido/cloudstack CLOUDSTACK-9141
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1220
----
commit d6b37001607d9b5f8514e48350ee3fee62328b90
Author: Wido den Hollander <wi...@widodh.nl>
Date: 2015-12-11T13:25:24Z
CLOUDSTACK-9141: Validate userdata for valid base64
This prevents the userdata from going through the stack completely
and finding out very late in the process that it is invalid data.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
Posted by wido <gi...@git.apache.org>.
Github user wido closed the pull request at:
https://github.com/apache/cloudstack/pull/1220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164167812
Time to move to Java 8, post 4.7 perhaps?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164168237
@bhaisaab Good idea to do that indeed. I think many of us want Java 8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164673949
Closing this one for now since it doesn't work on Java 7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164021612
@wido please have a look:
```
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/jenkins/jenkins-slave/workspace/cloudstack-pull-analysis/api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java:[63,16] error: cannot find symbol
[ERROR] symbol: class Base64
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164134556
@remibergsma Hmm, that's weird. It compiled on my desktop. This seems like a Java version thingy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---