You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/05 07:36:03 UTC

[GitHub] [spark] maropu opened a new pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

maropu opened a new pull request #31755:
URL: https://github.com/apache/spark/pull/31755


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   To support +8:00 in Spark3 when execute sql
   `select to_utc_timestamp("2020-02-07 16:00:00", "GMT+8:00")`
   
   This is the backport of #31624 and the original author is @Karl-WangSK .
   
   ### Why are the changes needed?
   +8:00 this format is supported in PostgreSQL,hive, presto, but not supported in Spark3
   https://issues.apache.org/jira/browse/SPARK-34392
   
   
   ### Does this PR introduce _any_ user-facing change?
   no
   
   
   ### How was this patch tested?
   unit test
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791266862


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40381/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791604568


   I was late. Thanks. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791280498


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40381/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791251950


   **[Test build #135799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135799/testReport)** for PR 31755 at commit [`b27ca75`](https://github.com/apache/spark/commit/b27ca75d8e772021cb785d82f87ab1bb4af4c39f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791221834


   cc: @srowen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791387589


   **[Test build #135799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135799/testReport)** for PR 31755 at commit [`b27ca75`](https://github.com/apache/spark/commit/b27ca75d8e772021cb785d82f87ab1bb4af4c39f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791403393


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135799/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791604145


   LOL I just tried to merge this as well. Hope it worked.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791280523


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40381/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791403393


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135799/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31755:
URL: https://github.com/apache/spark/pull/31755


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791280523


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40381/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791251950


   **[Test build #135799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135799/testReport)** for PR 31755 at commit [`b27ca75`](https://github.com/apache/spark/commit/b27ca75d8e772021cb785d82f87ab1bb4af4c39f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #31755: [SPARK-34392][SQL][3.0] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31755:
URL: https://github.com/apache/spark/pull/31755#issuecomment-791604349


   Oh. :)  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org