You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/03/21 12:57:41 UTC
[GitHub] [incubator-celeborn] waitinfuture opened a new pull request, #1371: 454
waitinfuture opened a new pull request, #1371:
URL: https://github.com/apache/incubator-celeborn/pull/1371
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Code refine for worker.
### Why are the changes needed?
Code refine for worker.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1371: [CELEBORN-454] Code refine for worker
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1371:
URL: https://github.com/apache/incubator-celeborn/pull/1371#issuecomment-1477864184
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1371](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08a6d61) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/56d796638f864a4a96913074115def80f7eb3fc9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56d7966) will **decrease** coverage by `0.09%`.
> The diff coverage is `47.83%`.
```diff
@@ Coverage Diff @@
## main #1371 +/- ##
============================================
- Coverage 29.86% 29.77% -0.09%
+ Complexity 917 910 -7
============================================
Files 220 222 +2
Lines 18498 18511 +13
Branches 1974 1974
============================================
- Hits 5523 5510 -13
- Misses 12585 12610 +25
- Partials 390 391 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...born/service/deploy/worker/storage/FileWriter.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvc3RvcmFnZS9GaWxlV3JpdGVyLmphdmE=) | `39.27% <ø> (+0.81%)` | :arrow_up: |
| [...he/celeborn/service/deploy/worker/Controller.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL0NvbnRyb2xsZXIuc2NhbGE=) | `0.00% <ø> (ø)` | |
| [...leborn/service/deploy/worker/PushDataHandler.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1B1c2hEYXRhSGFuZGxlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/celeborn/service/deploy/worker/Worker.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1dvcmtlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...orn/common/network/server/DataPartitionReader.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvRGF0YVBhcnRpdGlvblJlYWRlci5qYXZh) | `24.11% <50.00%> (ø)` | |
| [.../deploy/worker/storage/MapPartitionFileWriter.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvc3RvcmFnZS9NYXBQYXJ0aXRpb25GaWxlV3JpdGVyLmphdmE=) | `55.87% <73.08%> (+0.52%)` | :arrow_up: |
| [...java/org/apache/celeborn/common/meta/FileInfo.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbWV0YS9GaWxlSW5mby5qYXZh) | `33.34% <100.00%> (ø)` | |
... and [4 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1371/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1371: [CELEBORN-454] Code refine for worker
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1371:
URL: https://github.com/apache/incubator-celeborn/pull/1371#discussion_r1143379323
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -66,7 +66,7 @@ private[celeborn] class Worker(
workerArgs.host,
workerArgs.port,
conf,
- Math.max(64, Runtime.getRuntime.availableProcessors()))
+ Math.min(64, Runtime.getRuntime.availableProcessors()))
Review Comment:
modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1371: [CELEBORN-454] Code refine for worker
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1371:
URL: https://github.com/apache/incubator-celeborn/pull/1371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1371: [CELEBORN-454] Code refine for worker
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1371:
URL: https://github.com/apache/incubator-celeborn/pull/1371#discussion_r1143372226
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -66,7 +66,7 @@ private[celeborn] class Worker(
workerArgs.host,
workerArgs.port,
conf,
- Math.max(64, Runtime.getRuntime.availableProcessors()))
+ Math.min(64, Runtime.getRuntime.availableProcessors()))
Review Comment:
This change might introduce unexpected behavior. For example, if a worker runs in a single-core pod. This will hang workers which processing time-consuming RPC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org