[GitHub] [incubator-nuttx] v01d commented on issue #1416: nRF52 radio adaptation

[GitBox <gi...@apache.org>]

v01d commented on issue #1416:
URL: https://github.com/apache/incubator-nuttx/issues/1416#issuecomment-660493212


   > Don't like this. I don't see any added value in the proposed solution and more - it is less modular.
   
   I'd say there's unnecessary complexity right now. Anyway, I can live with it.
   
   > Remember that RADIO can be also used to implement simple proprietary protocols. The default interrupt logic can be useful in this case.
   > It may be better to provide a configuration option to disable default interrupts and expose the interrupts interface.
   
   I'm aware of other use cases but It would be best for the RADIO peripheral interface to not really implement behaviour on its own that conflicts with a given communication protocol. For BLE I will need to get tight into hardware, and the way the read/write methods are written right now (blocking on a mutex, triggered by the ISR) doesn't really allow much to be done differently one layer above. For any other protocol I would write the appropriate driver doing these things at that layer.
   
   I will continue working on BLE and see exactly what are the changes I would need to introduce to the RADIO interface. I will open a draft PR to show how it would look. Maybe this helps to think the best way to handle this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org