You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Martijn van Groningen (Created) (JIRA)" <ji...@apache.org> on 2011/10/03 22:43:35 UTC
[jira] [Created] (LUCENE-3483) Move Function grouping collectors
from Solr to grouping module
Move Function grouping collectors from Solr to grouping module
--------------------------------------------------------------
Key: LUCENE-3483
URL: https://issues.apache.org/jira/browse/LUCENE-3483
Project: Lucene - Java
Issue Type: Improvement
Components: modules/grouping
Affects Versions: 4.0
Reporter: Martijn van Groningen
Assignee: Martijn van Groningen
Priority: Minor
Fix For: 4.0
Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3483) Move Function grouping
collectors from Solr to grouping module
Posted by "Martijn van Groningen (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119589#comment-13119589 ]
Martijn van Groningen edited comment on LUCENE-3483 at 10/3/11 8:49 PM:
------------------------------------------------------------------------
Attached patch.
* I've put the collectors under o.a.s.grouping.function package.
* The grouping module depends on queries module in this patch.
* The tests inside grouping module randomly select a term based implementation or a ValueSource based implementation (Function*Collector implementation).
was (Author: martijn.v.groningen):
Attached patch.
* I've put the collectors under o.a.s.grouping.function package.
*The grouping module depends on queries module in this patch.
* The tests inside grouping module randomly select a term based implementation or a ValueSource based implementation (Function*Collector implementation).
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3483) Move Function grouping collectors
from Solr to grouping module
Posted by "Martijn van Groningen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen updated LUCENE-3483:
------------------------------------------
Attachment: LUCENE-3483.patch
Updated patch.
* Added some more documentation
* Added missing class: BytesRefFieldSource This class is now only used in the grouping test, but I think is usable outside this test case as well.
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch, LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3483) Move Function grouping collectors
from Solr to grouping module
Posted by "Martijn van Groningen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122220#comment-13122220 ]
Martijn van Groningen commented on LUCENE-3483:
-----------------------------------------------
Committed in r1179808
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch, LUCENE-3483.patch, LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3483) Move Function grouping collectors
from Solr to grouping module
Posted by "Yonik Seeley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121562#comment-13121562 ]
Yonik Seeley commented on LUCENE-3483:
--------------------------------------
Cool, thanks for the recap.
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch, LUCENE-3483.patch, LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3483) Move Function grouping collectors
from Solr to grouping module
Posted by "Martijn van Groningen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121525#comment-13121525 ]
Martijn van Groningen commented on LUCENE-3483:
-----------------------------------------------
I only moved the Term* collectors. As a result of that I needed to make two explicit changes:
* Changed visibility of SentinelIntSet from package protected to public.
* Minor documentation change in package.html
I could have moved SentinelIntSet to term package instead of changing visibilty, but now other users can use this class as well now. Maybe one day SentinelIntSet can move to core in a util package.
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch, LUCENE-3483.patch, LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3483) Move Function grouping
collectors from Solr to grouping module
Posted by "Martijn van Groningen (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121506#comment-13121506 ]
Martijn van Groningen edited comment on LUCENE-3483 at 10/5/11 9:40 PM:
------------------------------------------------------------------------
Updated patch.
* Updated to latest trunk changes.
* Moved Term* collectors to term package.
* Made SentinelIntSet public and added @lucene.internal to jdoc
I think it is time to commit this patch.
was (Author: martijn.v.groningen):
Updated patch.
* Updated to latest trunk changes.
* Moved Term* collectors to term package.
* Made SentinelIntSet public and added @lucene.internal to jdoc
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch, LUCENE-3483.patch, LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3483) Move Function grouping collectors
from Solr to grouping module
Posted by "Martijn van Groningen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen updated LUCENE-3483:
------------------------------------------
Attachment: LUCENE-3483.patch
Updated patch.
* Updated to latest trunk changes.
* Moved Term* collectors to term package.
* Made SentinelIntSet public and added @lucene.internal to jdoc
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch, LUCENE-3483.patch, LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3483) Move Function grouping collectors
from Solr to grouping module
Posted by "Martijn van Groningen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen updated LUCENE-3483:
------------------------------------------
Attachment: LUCENE-3483.patch
Attached patch.
* I've put the collectors under o.a.s.grouping.function package.
*The grouping module depends on queries module in this patch.
* The tests inside grouping module randomly select a term based implementation or a ValueSource based implementation (Function*Collector implementation).
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3483) Move Function grouping collectors
from Solr to grouping module
Posted by "Yonik Seeley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121516#comment-13121516 ]
Yonik Seeley commented on LUCENE-3483:
--------------------------------------
Unfortunately, context diffs are hard to review in these cases (when things move as opposed to just change).
Are the classes just being moved (with trivial changes such as package-private -> public, etc) or are there any additional changes/cleanups?
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch, LUCENE-3483.patch, LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3483) Move Function grouping collectors
from Solr to grouping module
Posted by "Martijn van Groningen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen resolved LUCENE-3483.
-------------------------------------------
Resolution: Fixed
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch, LUCENE-3483.patch, LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3483) Move Function grouping
collectors from Solr to grouping module
Posted by "Martijn van Groningen (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121525#comment-13121525 ]
Martijn van Groningen edited comment on LUCENE-3483 at 10/5/11 10:06 PM:
-------------------------------------------------------------------------
I only moved the Term* collectors. As a result of that I needed to make two explicit changes:
* Changed visibility of SentinelIntSet from package protected to public.
* Minor documentation change in package.html
I could have moved SentinelIntSet to term package instead of changing visibility, but now other users can use this class as well now. Maybe one day SentinelIntSet can move to core in a util package.
was (Author: martijn.v.groningen):
I only moved the Term* collectors. As a result of that I needed to make two explicit changes:
* Changed visibility of SentinelIntSet from package protected to public.
* Minor documentation change in package.html
I could have moved SentinelIntSet to term package instead of changing visibilty, but now other users can use this class as well now. Maybe one day SentinelIntSet can move to core in a util package.
> Move Function grouping collectors from Solr to grouping module
> --------------------------------------------------------------
>
> Key: LUCENE-3483
> URL: https://issues.apache.org/jira/browse/LUCENE-3483
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Affects Versions: 4.0
> Reporter: Martijn van Groningen
> Assignee: Martijn van Groningen
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3483.patch, LUCENE-3483.patch, LUCENE-3483.patch
>
>
> Move the Function*Collectors from Solr (inside Grouping source file) to grouping module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org