You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2017/12/15 23:15:30 UTC
[GitHub] ctubbsii commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates
ctubbsii commented on a change in pull request #342: ACCUMULO-4764 Move html from js to templates
URL: https://github.com/apache/accumulo/pull/342#discussion_r157316472
##########
File path: server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/overview.ftl
##########
@@ -19,8 +19,31 @@
<div class="center-block">
<div class="container">
<div class="row">
- <div class="col-md-6" id="master"></div>
- <div class="col-md-6" id="zookeeper"></div>
+ <div class="col-md-6" id="master">
+ <table class="table table-bordered table-striped table-condensed">
+ <tbody>
+ <tr><th colspan="2"><a href="/master">Accumulo Master</a></th></tr>
+ <tr><td colspan="2" class="center" style="display: none;"><span class="label label-danger">Master is Down</span></td></tr>
+ <tr><td class="left" style="display: table-cell;"><a href="/tables">Tables</a></td><td class="right" style="display: table-cell;"></td></tr>
+ <tr><td class="left" style="display: table-cell;"><a href="/tservers">Tablet Servers</a></td><td class="right" style="display: table-cell;"></td></tr>
+ <tr><td class="left" style="display: table-cell;"><a href="/tservers">Dead Tablet Servers</a></td><td class="right" style="display: table-cell;"></td></tr>
+ <tr><td class="left" style="display: table-cell;">Tablets</td><td class="right" style="display: table-cell;"></td></tr>
Review comment:
This is another place where inline styles could be replaced with a separate globally defined class or id CSS rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services