You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by ce...@apache.org on 2004/12/22 22:58:48 UTC
cvs commit: logging-log4j/src/java/org/apache/log4j/pattern ThrowableInformationPatternConverter.java
ceki 2004/12/22 13:58:48
Modified: src/java/org/apache/log4j/pattern
ThrowableInformationPatternConverter.java
Log:
Simplifications as discussed in log4j-dev
- Remove the setOption method
- Change PatternConverter.setOptions to be implemented as {}, i.e. NOP.
- Change sub-classes of PatternConverter dealing with options override the NOP implementaton in PatternConverter.setOptions.
Revision Changes Path
1.6 +15 -3 logging-log4j/src/java/org/apache/log4j/pattern/ThrowableInformationPatternConverter.java
Index: ThrowableInformationPatternConverter.java
===================================================================
RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/pattern/ThrowableInformationPatternConverter.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- ThrowableInformationPatternConverter.java 17 Sep 2004 17:33:31 -0000 1.5
+++ ThrowableInformationPatternConverter.java 22 Dec 2004 21:58:48 -0000 1.6
@@ -16,6 +16,8 @@
package org.apache.log4j.pattern;
+import java.util.List;
+
import org.apache.log4j.spi.LoggingEvent;
import org.apache.log4j.spi.ThrowableInformation;
@@ -29,6 +31,9 @@
*
*/
public class ThrowableInformationPatternConverter extends PatternConverter {
+
+ String option;
+
/* (non-Javadoc)
* @see org.apache.log4j.pattern.PatternConverter#convert(org.apache.log4j.spi.LoggingEvent)
*/
@@ -45,11 +50,11 @@
int length = 0;
- if (getOption() == null) {
+ if (option == null) {
length = stringRep.length;
- } else if (getOption().equals("full")) {
+ } else if (option.equals("full")) {
length = stringRep.length;
- } else if (getOption().equals("short")) {
+ } else if (option.equals("short")) {
length = 1;
} else {
length = stringRep.length;
@@ -63,6 +68,13 @@
return buf;
}
+ public void setOptions(List optionList) {
+ if(optionList == null || optionList.size() == 0) {
+ return;
+ }
+ option = (String) optionList.get(0);
+ }
+
public String getName() {
return "Throwable";
}
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org